Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 1166953007: Add workerReady timing for ServiceWorker controlled requests [3/3] (Closed)

Created:
5 years, 6 months ago by Kunihiko Sakamoto
Modified:
5 years, 6 months ago
Reviewers:
kinuko
CC:
blink-reviews, serviceworker-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@workerReady
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add workerReady timing for ServiceWorker controlled requests [3/3] To make ServiceWorker startup time measureable, in addition to workerStart, we need another timing "workerReady" which is the point ServiceWorker finished starting and is ready to handle events. This patch makes ResourceTiming's redirectStart (for redirected fetches) or fetchStart (for non-redirected fetches) return workerReady time, instead of workerStart. [1/3] https://codereview.chromium.org/1149273003/ [2/3] https://codereview.chromium.org/1146253004/ [3/3] THIS BUG=465640 TEST=http/tests/serviceworker/resource-timing.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196720

Patch Set 1 : #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M LayoutTests/http/tests/serviceworker/resource-timing.html View 1 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/timing/PerformanceResourceTiming.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/timing/PerformanceResourceTiming.cpp View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Kunihiko Sakamoto
ptal
5 years, 6 months ago (2015-06-08 05:38:33 UTC) #3
kinuko
lgtm
5 years, 6 months ago (2015-06-08 16:31:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166953007/40001
5 years, 6 months ago (2015-06-09 00:54:32 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 00:58:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196720

Powered by Google App Engine
This is Rietveld 408576698