Android buildbot fixes

Android buildbot fixes

- Move adb restart commands so they are only run on tests.
- Sleep after 'adb start-server' to avoid the false positive device alerts.
- Save Test Report logs with unique filename so they are easier to print.

BUG=163476, 165999
TBR=frankf

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174596

[frankf, 2012-12-26 18:23:59]

Why did you TBR this change? This is a collection changes for unrelated p2
issues. Don't misuse the TBR feature to bypass the review process.

https://codereview.chromium.org/11669022/diff/1004/build/android/pylib/test_r...
File build/android/pylib/test_result.py (right):

https://codereview.chromium.org/11669022/diff/1004/build/android/pylib/test_r...
build/android/pylib/test_result.py:138: log_file_path, re.sub('\W', '_',
test_type).lower() + '.log')
how are the files unique after this change?

[Isaac (away), 2012-12-26 19:24:14]

There are various reasons for a TBR and one is for small changes that block
other things and are expected to be non-controversial and non-breaking.  If you
have objection to this patch I can do a follow up after break.

https://codereview.chromium.org/11669022/diff/1004/build/android/pylib/test_r...
File build/android/pylib/test_result.py (right):

https://codereview.chromium.org/11669022/diff/1004/build/android/pylib/test_r...
build/android/pylib/test_result.py:138: log_file_path, re.sub('\W', '_',
test_type).lower() + '.log')
On 2012/12/26 18:23:59, frankf wrote:
> how are the files unique after this change?

They make it easier to differentiate the log files with the .json files in the
same directory.

[klundberg, 2012-12-26 20:51:40]

I agree with Frank and would prefer that changes like this aren't TBR'ed.