Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: build/android/pylib/test_result.py

Issue 11669022: Android buildbot fixes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/buildbot/buildbot_functions.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/test_result.py
diff --git a/build/android/pylib/test_result.py b/build/android/pylib/test_result.py
index fba9ef1240e789ac292c23ed15cf6eae9d348ebd..28258da2a8d278113310b9046ff3f7da43362a3e 100644
--- a/build/android/pylib/test_result.py
+++ b/build/android/pylib/test_result.py
@@ -6,6 +6,7 @@
import json
import logging
import os
+import re
import time
import traceback
@@ -133,7 +134,8 @@ class TestResults(object):
build_type, 'test_logs')
if not os.path.exists(log_file_path):
os.mkdir(log_file_path)
- full_file_name = os.path.join(log_file_path, test_type)
+ full_file_name = os.path.join(
+ log_file_path, re.sub('\W', '_', test_type).lower() + '.log')
frankf 2012/12/26 18:23:59 how are the files unique after this change?
Isaac (away) 2012/12/26 19:24:14 They make it easier to differentiate the log files
if not os.path.exists(full_file_name):
with open(full_file_name, 'w') as log_file:
print >> log_file, '\n%s results for %s build %s:' % (
« no previous file with comments | « build/android/buildbot/buildbot_functions.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698