Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: tests/language/invocation_mirror_test.dart

Issue 11669015: Turn compile time errors related to missing getters and setters into invocation (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/assign_top_method_test.dart ('k') | tests/language/language.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/invocation_mirror_test.dart
===================================================================
--- tests/language/invocation_mirror_test.dart (revision 16462)
+++ tests/language/invocation_mirror_test.dart (working copy)
@@ -41,8 +41,8 @@
if (positional == null) {
Expect.isTrue(im.isGetter, "$name:isGetter");
Expect.isFalse(im.isSetter, "$name:isSetter");
- Expect.equals(null, im.positionalArguments, "$name:positional");
- Expect.equals(null, im.namedArguments, "$name:named");
+ Expect.equals(0, im.positionalArguments.length, "$name:#positional");
+ Expect.equals(0, im.namedArguments.length, "$name:#named");
Lasse Reichstein Nielsen 2013/01/02 09:59:29 This change is incorrect. The API specification fo
regis 2013/01/02 17:37:21 The Language Spec has refined the description of t
return;
}
Expect.isTrue(im.isSetter, "$name:isSetter");
@@ -50,7 +50,7 @@
Expect.equals(1, im.positionalArguments.length, "$name:#positional");
Expect.equals(positional[0], im.positionalArguments[0],
"$name:positional[0]");
- Expect.equals(null, im.namedArguments, "$name:named");
+ Expect.equals(0, im.namedArguments.length, "$name:#named");
return;
}
Expect.isTrue(im.isMethod, "$name:isMethod");
@@ -166,7 +166,7 @@
testInvocationMirror(super - 4, '-', [4], {});
testInvocationMirror(-super, 'unary-', [], {});
testInvocationMirror(super[42], '[]', [42], {});
- testInvocationMirror((super[37] = 42).last, '[]=', [37, 42], {});
+ testInvocationMirror((){super[37] = 42; return last;}(), '[]=', [37, 42], {});
// Wrong arguments to existing function.
testInvocationMirror(super.flif(), "flif", [], {});
@@ -234,7 +234,7 @@
test(() => o.toString(x: 37));
test(() => o.hashCode = 42);
test(() => o.hashCode()); // Thrown by int.noSuchMethod.
- test(n.flif); // Extracted method has no noSuchMethod.
+ test(() => (n.flif)()); // Extracted method has no noSuchMethod.
}
main() {
« no previous file with comments | « tests/language/assign_top_method_test.dart ('k') | tests/language/language.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698