Turn compile time errors related to missing getters and setters into invocation

tests/language/invocation_mirror_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // InvocationMirror and noSuchMethod testing.
 
 /** Class with noSuchMethod that returns the mirror */
 class N {
   // Storage for the last argument to noSuchMethod.
   // Needed for setters, which don't evaluate to the return value.
@@ skipping 23 matching lines @@
 testInvocationMirror(InvocationMirror im, String name,
                      [List positional, Map named]) {
   Expect.isTrue(im is InvocationMirror, "is InvocationMirror");
   Expect.equals(name, im.memberName, "name");
   if (named == null) {
     Expect.isTrue(im.isAccessor, "$name:isAccessor");
     Expect.isFalse(im.isMethod, "$name:isMethod");
     if (positional == null) {
       Expect.isTrue(im.isGetter, "$name:isGetter");
       Expect.isFalse(im.isSetter, "$name:isSetter");
-      Expect.equals(null, im.positionalArguments, "$name:positional");
-      Expect.equals(null, im.namedArguments, "$name:named");
+      Expect.equals(0, im.positionalArguments.length, "$name:#positional");
+      Expect.equals(0, im.namedArguments.length, "$name:#named");

[Lasse Reichstein Nielsen, 2013/01/02 09:59:29]

This change is incorrect.
The API specification for InvocationMirror states that if isGetter is true, then
both positional and named arguments must be null.
Now, I'm quite open to changing that if you have reasons to prefer using empty
unmodifiable collections instead - it's actually quite reasonable, and if you
have the (reusable) objects anyway, it should be no more expensive than passing
null.

[regis, 2013/01/02 17:37:21]

The Language Spec has refined the description of the InvocationMirror instance
passed to noSuchMethod(). In the case of a getter, positionalArguments is an
empty array and namedArguments is an empty map. Please, update the API spec
accordingly. Thanks.

       return;
     }
     Expect.isTrue(im.isSetter, "$name:isSetter");
     Expect.isFalse(im.isGetter, "$name:isGetter");
     Expect.equals(1, im.positionalArguments.length, "$name:#positional");
     Expect.equals(positional[0], im.positionalArguments[0],
                   "$name:positional[0]");
-    Expect.equals(null, im.namedArguments, "$name:named");
+    Expect.equals(0, im.namedArguments.length, "$name:#named");
     return;
   }
   Expect.isTrue(im.isMethod, "$name:isMethod");
   Expect.isFalse(im.isAccessor, "$name:isAccessor");
   Expect.isFalse(im.isSetter, "$name:isSetter");
   Expect.isFalse(im.isGetter, "$name:isGetter");
 
   Expect.equals(positional.length, im.positionalArguments.length);
   for (int i = 0; i < positional.length; i++) {
     Expect.equals(positional[i], im.positionalArguments[i],
@@ skipping 95 matching lines @@
     testInvocationMirror(super.bar(), 'bar', [], {});
     testInvocationMirror(super.bar(42), 'bar', [42], {});
     testInvocationMirror(super.bar(x: 42), 'bar', [], {"x": 42});
     testInvocationMirror(super.bar(37, x: 42), 'bar', [37], {"x": 42});
 
     // Missing operator access.
     testInvocationMirror(super + 4, '+', [4], {});
     testInvocationMirror(super - 4, '-', [4], {});
     testInvocationMirror(-super, 'unary-', [], {});
     testInvocationMirror(super[42], '[]', [42], {});
-    testInvocationMirror((super[37] = 42).last, '[]=', [37, 42], {});
+    testInvocationMirror((){super[37] = 42; return last;}(), '[]=', [37, 42], {});
 
     // Wrong arguments to existing function.
     testInvocationMirror(super.flif(), "flif", [], {});
     testInvocationMirror(super.flif(37, 42), "flif", [37, 42], {});
     testInvocationMirror(super.flif(x: 42), "flif", [], {"x": 42});
     testInvocationMirror(super.flif(37, x: 42), "flif", [37], {"x": 42});
     testInvocationMirror((){super.flif = 42; return last;}(), "flif=", [42]);
 
     testInvocationMirror(super.flaf(37, 42), "flaf", [37, 42], {});
     testInvocationMirror(super.flaf(x: 42), "flaf", [], {"x": 42});
@@ skipping 47 matching lines @@
   test(() => o + 2);
   test(() => -o);
   test(() => o[0]);
   test(() => o[0] = 42);
   test(() => o());
   test(() => o.toString = 42);
   test(() => o.toString(42));
   test(() => o.toString(x: 37));
   test(() => o.hashCode = 42);
   test(() => o.hashCode());  // Thrown by int.noSuchMethod.
-  test(n.flif);  // Extracted method has no noSuchMethod.
+  test(() => (n.flif)());  // Extracted method has no noSuchMethod.
 }
 
 main() {
   testInvocationMirrors();
   testNoSuchMethodErrors();
   new M().testSuperCalls();
 }