Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: components/filesystem/public/interfaces/file.mojom

Issue 1166763002: Reland "Mandoline filesystem: Build the filesystem on windows." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DWORD -> INT for real checking. (This was wrong.) Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/filesystem/public/interfaces/file.mojom
diff --git a/components/filesystem/public/interfaces/file.mojom b/components/filesystem/public/interfaces/file.mojom
index 8148ec414a48c20a09d39664cbfbffb69f7cb9ef..306b9f78fe4c0b1bbb6bac07d1bd2f07d3eddd78 100644
--- a/components/filesystem/public/interfaces/file.mojom
+++ b/components/filesystem/public/interfaces/file.mojom
@@ -16,7 +16,7 @@ interface File {
// Flushes/closes this file; no operations may be performed on this file after
// this. Note that any error code is strictly informational -- the close may
// not be retried.
- Close() => (Error err);
+ Close() => (FileError err);
// Reads (at most) |num_bytes_to_read| from the location specified by
// |offset|/|whence|. On success, |bytes_read| is set to the data read.
@@ -25,40 +25,40 @@ interface File {
// TODO(vtl): Clarify when (for what values of |offset|/|whence|) this
// modifies the file position. Or maybe there should be a flag?
Read(uint32 num_bytes_to_read, int64 offset, Whence whence)
- => (Error error, array<uint8>? bytes_read);
+ => (FileError error, array<uint8>? bytes_read);
// Writes |bytes_to_write| to the location specified by |offset|/|whence|.
// TODO(vtl): Clarify behavior when |num_bytes_written| is less than the size
// of |bytes_to_write|.
Write(array<uint8> bytes_to_write, int64 offset, Whence whence)
- => (Error error, uint32 num_bytes_written);
+ => (FileError error, uint32 num_bytes_written);
// Gets the current file position. On success, |position| is the current
// offset (in bytes) from the beginning of the file).
- Tell() => (Error error, int64 position);
+ Tell() => (FileError error, int64 position);
// Sets the current file position to that specified by |offset|/|whence|. On
// success, |position| is the offset (in bytes) from the beginning of the
// file.
- Seek(int64 offset, Whence whence) => (Error error, int64 position);
+ Seek(int64 offset, Whence whence) => (FileError error, int64 position);
// Gets information about this file. On success, |file_information| is
// non-null and will contain this information.
- Stat() => (Error error, FileInformation? file_information);
+ Stat() => (FileError error, FileInformation? file_information);
// Truncates this file to the size specified by |size| (in bytes).
- Truncate(int64 size) => (Error error);
+ Truncate(int64 size) => (FileError error);
// Updates this file's atime and/or mtime to the time specified by |atime| (or
// |mtime|, respectively), which may also indicate "now". If |atime| or
// |mtime| is null, then the corresponding time is not modified.
- Touch(TimespecOrNow? atime, TimespecOrNow? mtime) => (Error error);
+ Touch(TimespecOrNow? atime, TimespecOrNow? mtime) => (FileError error);
// Creates a new |File| instance, which shares the same "file description".
// I.e., the access mode, etc. (as specified to |Directory::OpenFile()| by the
// |open_flags| argument) as well as file position.
- Dup(File& file) => (Error error);
+ Dup(File& file) => (FileError error);
// Returns a handle to the file for raw access.
- AsHandle() => (Error error, handle file_handle);
+ AsHandle() => (FileError error, handle file_handle);
};
« no previous file with comments | « components/filesystem/public/interfaces/directory.mojom ('k') | components/filesystem/public/interfaces/file_system.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698