Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1166693006: clang/win/gn: Pass -msse flags to clang-cl.exe (Closed)

Created:
5 years, 6 months ago by Nico
Modified:
5 years, 6 months ago
Reviewers:
Johann, Tom Finegan
CC:
wwcv, jzern, fgalligan1, Tom Finegan
Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Nico
First to stamp wins!
5 years, 6 months ago (2015-06-04 20:17:10 UTC) #2
Tom Finegan
I'm a winner! \o/ lgtm
5 years, 6 months ago (2015-06-04 20:23:02 UTC) #3
Johann
On 2015/06/04 20:23:02, Tom Finegan wrote: > I'm a winner! \o/ > > lgtm Winner ...
5 years, 6 months ago (2015-06-04 20:24:30 UTC) #4
Nico
Committed patchset #1 (id:1) manually as a43631169b4200f2000c8cfa82404ce507e31486 (presubmit successful).
5 years, 6 months ago (2015-06-04 20:25:06 UTC) #6
Nico
Congrats! Looks like `git cl land` worked for me: https://chromium.googlesource.com/chromium/deps/libvpx/+/a43631169b4200f2000c8cfa82404ce507e31486
5 years, 6 months ago (2015-06-04 20:25:32 UTC) #7
Johann
On 2015/06/04 20:25:06, Nico wrote: > Committed patchset #1 (id:1) manually as > a43631169b4200f2000c8cfa82404ce507e31486 (presubmit ...
5 years, 6 months ago (2015-06-04 20:25:42 UTC) #8
Johann
On 2015/06/04 20:25:32, Nico wrote: > Congrats! > > Looks like `git cl land` worked ...
5 years, 6 months ago (2015-06-04 20:26:34 UTC) #9
Johann
5 years, 6 months ago (2015-06-04 20:26:36 UTC) #10
Message was sent while issue was closed.
On 2015/06/04 20:25:32, Nico wrote:
> Congrats!
> 
> Looks like `git cl land` worked for me:
>
https://chromium.googlesource.com/chromium/deps/libvpx/+/a43631169b4200f2000c...

Good because my attempt to move libvpx out of DEPS has stalled (going on vaca
soon, will dig into it sometime later)

Powered by Google App Engine
This is Rietveld 408576698