Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1166683003: Handle SVGLength resolving in an inactive document gracefully (Closed)

Created:
5 years, 6 months ago by fs
Modified:
5 years, 6 months ago
Reviewers:
pdr.
CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, f(malita), gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Handle SVGLength resolving in an inactive document gracefully If the element associated with the SVGLength is in an inactive document, there'll be no layout, so computedStyleForLengthResolving() will be able to exit the loop without finding a ComputedStyle to return. BUG=493977 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
A LayoutTests/svg/dom/SVGLength-value-in-inactive-document.html View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/svg/dom/SVGLength-value-in-inactive-document-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGLengthContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
<boyband-voice>Taking the easy way out...</boyband-voice>
5 years, 6 months ago (2015-06-01 15:01:26 UTC) #2
pdr.
On 2015/06/01 at 15:01:26, fs wrote: > <boyband-voice>Taking the easy way out...</boyband-voice> MMMBop LGTM
5 years, 6 months ago (2015-06-02 01:30:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166683003/1
5 years, 6 months ago (2015-06-02 01:32:05 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 01:35:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196269

Powered by Google App Engine
This is Rietveld 408576698