Issue 1166683003: Handle SVGLength resolving in an inactive document gracefully

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1166683003: Handle SVGLength resolving in an inactive document gracefully (Closed)

Created:
5 years, 6 months ago by fs

Modified:
5 years, 6 months ago

Reviewers:
pdr.

CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, f(malita), gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Handle SVGLength resolving in an inactive document gracefully If the element associated with the SVGLength is in an inactive document, there'll be no layout, so computedStyleForLengthResolving() will be able to exit the loop without finding a ComputedStyle to return. BUG=493977 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196269

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -2 lines)			Patch
A	LayoutTests/svg/dom/SVGLength-value-in-inactive-document.html	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/dom/SVGLength-value-in-inactive-document-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/svg/SVGLengthContext.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pdr.

On 2015/06/01 at 15:01:26, fs wrote: > <boyband-voice>Taking the easy way out...</boyband-voice> MMMBop LGTM

5 years, 6 months ago (2015-06-02 01:30:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166683003/1

5 years, 6 months ago (2015-06-02 01:32:05 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-02 01:35:42 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196269

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages