Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1915)

Unified Diff: Source/core/svg/SVGLengthContext.cpp

Issue 1166683003: Handle SVGLength resolving in an inactive document gracefully (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/svg/dom/SVGLength-value-in-inactive-document-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGLengthContext.cpp
diff --git a/Source/core/svg/SVGLengthContext.cpp b/Source/core/svg/SVGLengthContext.cpp
index 64a81dc98699c57e63e50401072efcbf735cdd86..50e381f3e9e6e7ec4a973cc2749a37a8e21af1d0 100644
--- a/Source/core/svg/SVGLengthContext.cpp
+++ b/Source/core/svg/SVGLengthContext.cpp
@@ -65,8 +65,8 @@ static const ComputedStyle* computedStyleForLengthResolving(const SVGElement* co
currentContext = currentContext->parentNode();
} while (currentContext);
- // There must be at least a LayoutSVGRoot layoutObject, carrying a style.
- ASSERT_NOT_REACHED();
+ // We can end up here if trying to resolve values for elements in an
+ // inactive document.
return nullptr;
}
« no previous file with comments | « LayoutTests/svg/dom/SVGLength-value-in-inactive-document-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698