Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 11665030: Fixing Element.matches to be cross-platform and follow latest spec. (Closed)

Created:
7 years, 12 months ago by blois
Modified:
7 years, 11 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing Element.matches to be cross-platform and follow latest spec. BUG=4401 Committed: https://code.google.com/p/dart/source/detail?r=16829

Patch Set 1 #

Patch Set 2 : Adding experimental annotation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -9 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 3 chunks +16 lines, -5 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +1 line, -2 lines 0 comments Download
M sdk/lib/html/scripts/generator.py View 1 1 chunk +6 lines, -0 lines 0 comments Download
M sdk/lib/html/scripts/htmlrenamer.py View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/scripts/systemhtml.py View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_DocumentFragment.darttemplate View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/html/templates/html/impl/impl_Element.darttemplate View 1 1 chunk +16 lines, -0 lines 0 comments Download
M tests/html/element_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
blois
7 years, 12 months ago (2012-12-26 18:36:32 UTC) #1
Jennifer Messerly
7 years, 11 months ago (2013-01-07 20:26:11 UTC) #2
lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698