sdk/lib/html/dartium/html_dartium.dart - Issue 11665030: Fixing Element.matches to be cross-platform and follow latest spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 11665030: Fixing Element.matches to be cross-platform and follow latest spec. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Adding experimental annotation. Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: sdk/lib/html/dartium/html_dartium.dart

diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart

index 7812866012d0fdcee5ccfccf3e3d88bd693b7359..aeb44463c3d09a5697d33e598d561cd9fee578a5 100644

--- a/sdk/lib/html/dartium/html_dartium.dart

+++ b/sdk/lib/html/dartium/html_dartium.dart

@@ -7473,7 +7473,6 @@ class DocumentFragment extends Node {

_emptyStyleFuture();

Future<CssStyleDeclaration> getComputedStyle(String pseudoElement) =>

_emptyStyleFuture();

- bool matchesSelector(String selectors) => false;

// Imperative Element methods are made into no-ops, as they are on parentless

// elements.

@@ -9318,7 +9317,7 @@ abstract class Element extends Node implements ElementTraversal {

/** @domName Element.webkitMatchesSelector */

- bool matchesSelector(String selectors) native "Element_webkitMatchesSelector_Callback";

+ bool matches(String selectors) native "Element_webkitMatchesSelector_Callback";

/** @domName Element.webkitRequestFullScreen */

« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | sdk/lib/html/scripts/generator.py » ('j') | no next file with comments »