Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1166373006: Prefer to use the AccountID to the Email from ListAccounts. (Closed)

Created:
5 years, 6 months ago by Mike Lerman
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prefer to use the AccountID to the Email from ListAccounts. This CL follows https://codereview.chromium.org/1162103003/ BUG=492787 Committed: https://crrev.com/f91ef5151598b01fdca8ebf9ad94b01f4b1cf22e Cr-Commit-Position: refs/heads/master@{#333586}

Patch Set 1 #

Patch Set 2 : comment #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -67 lines) Patch
M chrome/browser/signin/account_reconcilor_unittest.cc View 12 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/signin/cross_device_promo_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/signin/fake_gaia_cookie_manager_service.h View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/signin/fake_gaia_cookie_manager_service.cc View 1 chunk +11 lines, -10 lines 0 comments Download
M chrome/browser/signin/signin_manager_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M components/signin/core/browser/account_reconcilor.cc View 4 chunks +14 lines, -29 lines 0 comments Download
M components/signin/core/browser/gaia_cookie_manager_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M google_apis/gaia/gaia_auth_util.cc View 1 1 chunk +10 lines, -4 lines 3 comments Download

Messages

Total messages: 9 (2 generated)
Mike Lerman
Hi Roger, Second CL that moves services that consume ListAccounts responses onto using AccountID instead ...
5 years, 6 months ago (2015-06-09 19:08:02 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm https://codereview.chromium.org/1166373006/diff/20001/google_apis/gaia/gaia_auth_util.cc File google_apis/gaia/gaia_auth_util.cc (right): https://codereview.chromium.org/1166373006/diff/20001/google_apis/gaia/gaia_auth_util.cc#newcode61 google_apis/gaia/gaia_auth_util.cc:61: } Maybe DHCECK that either both |id|s are ...
5 years, 6 months ago (2015-06-09 19:16:52 UTC) #3
Mike Lerman
https://codereview.chromium.org/1166373006/diff/20001/google_apis/gaia/gaia_auth_util.cc File google_apis/gaia/gaia_auth_util.cc (right): https://codereview.chromium.org/1166373006/diff/20001/google_apis/gaia/gaia_auth_util.cc#newcode61 google_apis/gaia/gaia_auth_util.cc:61: } On 2015/06/09 19:16:52, Roger Tawa wrote: > Maybe ...
5 years, 6 months ago (2015-06-09 19:29:20 UTC) #4
Roger Tawa OOO till Jul 10th
https://codereview.chromium.org/1166373006/diff/20001/google_apis/gaia/gaia_auth_util.cc File google_apis/gaia/gaia_auth_util.cc (right): https://codereview.chromium.org/1166373006/diff/20001/google_apis/gaia/gaia_auth_util.cc#newcode61 google_apis/gaia/gaia_auth_util.cc:61: } On 2015/06/09 19:29:20, Mike Lerman wrote: > On ...
5 years, 6 months ago (2015-06-09 19:33:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166373006/20001
5 years, 6 months ago (2015-06-09 19:55:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-09 22:10:07 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 22:12:13 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f91ef5151598b01fdca8ebf9ad94b01f4b1cf22e
Cr-Commit-Position: refs/heads/master@{#333586}

Powered by Google App Engine
This is Rietveld 408576698