Chromium Code Reviews

Unified Diff: components/signin/core/browser/gaia_cookie_manager_service.cc

Issue 1166373006: Prefer to use the AccountID to the Email from ListAccounts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « components/signin/core/browser/account_reconcilor.cc ('k') | google_apis/gaia/gaia_auth_util.cc » ('j') | google_apis/gaia/gaia_auth_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/signin/core/browser/gaia_cookie_manager_service.cc
diff --git a/components/signin/core/browser/gaia_cookie_manager_service.cc b/components/signin/core/browser/gaia_cookie_manager_service.cc
index 4db5fa6ecb4e4f0b7af77fc87fe25edc176e4e34..4beff36cbccc78951d073ada993e79b2978602a5 100644
--- a/components/signin/core/browser/gaia_cookie_manager_service.cc
+++ b/components/signin/core/browser/gaia_cookie_manager_service.cc
@@ -561,7 +561,8 @@ void GaiaCookieManagerService::OnListAccountsSuccess(const std::string& data) {
return;
}
- for (gaia::ListedAccount account : listed_accounts_) {
+ for (gaia::ListedAccount& account : listed_accounts_) {
+ DCHECK(account.id.empty());
account.id = AccountTrackerService::PickAccountIdForAccount(
signin_client_->GetPrefs(), account.gaia_id, account.email);
}
« no previous file with comments | « components/signin/core/browser/account_reconcilor.cc ('k') | google_apis/gaia/gaia_auth_util.cc » ('j') | google_apis/gaia/gaia_auth_util.cc » ('J')

Powered by Google App Engine