Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1166353005: MIPS: Skip test-heap/TestSizeOfRegExpCode (Closed)

Created:
5 years, 6 months ago by paul.l...
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Skip test-heap/TestSizeOfRegExpCode After https://codereview.chromium.org/1180433003 the code-size exceeeds the limit for MIPS. We have some optimizations in place for MIPS64 that will be ported back to MIPS, and will investigate other code-size improvements so we can re-enable this test. BUG= Committed: https://crrev.com/18f4203577640c9f475e0f6ee83f906c79437297 Cr-Commit-Position: refs/heads/master@{#28913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/cctest/cctest.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166353005/1
5 years, 6 months ago (2015-06-10 17:13:13 UTC) #2
paul.l...
PTAL, this should get the bots green again.
5 years, 6 months ago (2015-06-10 17:15:05 UTC) #4
Michael Achenbach
lgtm
5 years, 6 months ago (2015-06-10 17:16:11 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-10 17:40:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166353005/1
5 years, 6 months ago (2015-06-10 17:45:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 17:47:25 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 17:47:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18f4203577640c9f475e0f6ee83f906c79437297
Cr-Commit-Position: refs/heads/master@{#28913}

Powered by Google App Engine
This is Rietveld 408576698