Reland II of 'Optimize trivial regexp disjunctions' CL 1176453002

Reland II of 'Optimize trivial regexp disjunctions' CL 1176453002

This change rewrites regexps like (ab|ac|z|ad|ae|af) into (a[b-f]|z).  We can only reorder disjunctions like this for case-dependent regexps.  For case-independent regexps, the disjunctions should be pre-sorted for best results.

R=yangguo@chromium.org
BUG=chromium:482998
LOG=n

Committed: https://crrev.com/05507cc3ea6e96e9e9df98d276c235eea32374dd
Cr-Commit-Position: refs/heads/master@{#28902}

[Erik Corry Chromium.org, 2015-06-10 09:15:47]

https://codereview.chromium.org/1180433003/diff/1/src/jsregexp.cc
File src/jsregexp.cc (right):

https://codereview.chromium.org/1180433003/diff/1/src/jsregexp.cc#newcode4845
src/jsregexp.cc:4845: if (i == length) break;
This line is fix 1 vs. the original CL.

https://codereview.chromium.org/1180433003/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://codereview.chromium.org/1180433003/diff/1/test/cctest/test-heap.cc#ne...
test/cctest/test-heap.cc:1789: if (!FLAG_debug_code) {
This "if" is fix 2 vs. the original CL.

[Erik Corry Chromium.org, 2015-06-10 09:15:53]

The CQ bit was checked by erikcorry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-10 09:16:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180433003/1

[Yang, 2015-06-10 09:20:45]

On 2015/06/10 09:16:02, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1180433003/1

lgtm. but the test case seems to be missing?

[Erik Corry Chromium.org, 2015-06-10 09:27:17]

Well spotted.  I re-added the test, and took the opportunity to rename it from
regress-chromium-482998.js to regress-crbug-482998.js which is more inline with
the names of other tests.

[Erik Corry Chromium.org, 2015-06-10 09:27:33]

The CQ bit was checked by erikcorry@chromium.org

[Erik Corry Chromium.org, 2015-06-10 09:27:33]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1180433003/#ps20001
(title: "Re-add test")

[commit-bot: I haz the power, 2015-06-10 09:27:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180433003/20001

[commit-bot: I haz the power, 2015-06-10 09:55:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-10 09:55:37]

Patchset 2 (id:??) landed as
https://crrev.com/05507cc3ea6e96e9e9df98d276c235eea32374dd
Cr-Commit-Position: refs/heads/master@{#28902}