Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1166203002: Rename Container's desiredSize argument to width and height arguments. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename Container's desiredSize argument to width and height arguments. Also change SizedBox. This makes the code that uses Container() and SizedBox() much more readable. The underlying RenderSizedBox is not affected by this change. R=abarth@chromium.org, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bb52ac369024ec1e3bab40c63251c94525d3e4fa

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -32 lines) Patch
M sky/examples/fn2/container.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/stocks2/lib/stock_row.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/framework/components2/checkbox.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/drawer.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M sky/sdk/lib/framework/components2/drawer_header.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M sky/sdk/lib/framework/components2/floating_action_button.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/menu_divider.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/framework/components2/menu_item.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/radio.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/scaffold.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/framework/components2/tool_bar.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 1 4 chunks +16 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eseidel
Shrug. Not sure I'm the best reviewer, but lgtm if you need it.
5 years, 6 months ago (2015-06-08 20:56:46 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/1166203002/diff/1/sky/sdk/lib/framework/fn2.dart File sky/sdk/lib/framework/fn2.dart (right): https://codereview.chromium.org/1166203002/diff/1/sky/sdk/lib/framework/fn2.dart#newcode991 sky/sdk/lib/framework/fn2.dart:991: current = new SizedBox(height: height, child: current); if ...
5 years, 6 months ago (2015-06-08 21:09:01 UTC) #4
Hixie
5 years, 6 months ago (2015-06-08 21:36:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bb52ac369024ec1e3bab40c63251c94525d3e4fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698