sky/sdk/lib/framework/components2/drawer_header.dart - Issue 1166203002: Rename Container's desiredSize argument to width and height arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/framework/components2/drawer_header.dart

Issue 1166203002: Rename Container's desiredSize argument to width and height arguments. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sky/sdk/lib/framework/components2/drawer.dart ('k') | sky/sdk/lib/framework/components2/floating_action_button.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/sdk/lib/framework/components2/drawer_header.dart

diff --git a/sky/sdk/lib/framework/components2/drawer_header.dart b/sky/sdk/lib/framework/components2/drawer_header.dart

index 9c39817715c281e3e2a03faf6d43b4d3e37f2fa7..ac3da43fab133ac34b9a7c6cb26a7949345372e9 100644

--- a/sky/sdk/lib/framework/components2/drawer_header.dart

+++ b/sky/sdk/lib/framework/components2/drawer_header.dart

@@ -15,7 +15,7 @@ class DrawerHeader extends Component {

UINode build() {

return new Container(

key: 'drawer-header-outside',

- desiredSize: const Size.fromHeight(kStatusBarHeight + kMaterialDrawerHeight),

+ height: kStatusBarHeight + kMaterialDrawerHeight,

decoration: new BoxDecoration(

backgroundColor: BlueGrey[50],

border: const Border(

@@ -31,10 +31,7 @@ class DrawerHeader extends Component {

key: 'drawer-header-inside',

direction: FlexDirection.vertical,

children: [

- new FlexExpandingChild(new Container(

- key: 'drawer-header-spacer',

- desiredSize: Size.infinite

- )),

+ new FlexExpandingChild(new Container(key: 'drawer-header-spacer')),

new Container(

key: 'drawer-header-label',

padding: const EdgeDims.symmetric(horizontal: 16.0),

« no previous file with comments | « sky/sdk/lib/framework/components2/drawer.dart ('k') | sky/sdk/lib/framework/components2/floating_action_button.dart » ('j') | no next file with comments »