Tell java side when the native auth handler is gone

Tell java side when the native auth handler is gone

This is to stop the app keeping and using a reference to the native
class after it was deleted.
Also fixed up the destructor chain threading, to delete the auth
handler on the UI thread.

BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174633

[Kristian Monsen, 2012-12-22 02:39:04]

Can there be some threading issues, or are the java methods called from the same
thread as the destructor?

https://codereview.chromium.org/11661013/diff/1/android_webview/java/src/org/...
File
android_webview/java/src/org/chromium/android_webview/AwHttpAuthHandler.java
(right):

https://codereview.chromium.org/11661013/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwHttpAuthHandler.java:17:
if (mNativeAwHttpAuthHandler != 0) {
Use null in Java

[joth, 2012-12-22 02:55:16]

Good question on threading. should be fine, as these are all UI thread methods.

https://codereview.chromium.org/11661013/diff/1/android_webview/java/src/org/...
File
android_webview/java/src/org/chromium/android_webview/AwHttpAuthHandler.java
(right):

https://codereview.chromium.org/11661013/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwHttpAuthHandler.java:17:
if (mNativeAwHttpAuthHandler != 0) {
On 2012/12/22 02:39:04, kristianm1 wrote:
> Use null in Java

won't compile: it's an int. (native ptr)

[commit-bot: I haz the power, 2012-12-22 02:55:32]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Kristian Monsen, 2012-12-22 03:01:58]

lgtm

I was wondering if the destructor will be on the UI thread as well. Could maybe
add a DCHECK?

https://codereview.chromium.org/11661013/diff/1/android_webview/java/src/org/...
File
android_webview/java/src/org/chromium/android_webview/AwHttpAuthHandler.java
(right):

https://codereview.chromium.org/11661013/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwHttpAuthHandler.java:17:
if (mNativeAwHttpAuthHandler != 0) {
On 2012/12/22 02:55:16, joth wrote:
> On 2012/12/22 02:39:04, kristianm1 wrote:
> > Use null in Java
> 
> won't compile: it's an int. (native ptr)

Oh right, and it is just temporary stored here. Sorry about that, just looked
weird in Java code.

[boliu, 2012-12-22 03:28:54]

committer lgtm

cq uses HEAD so should not have apply_issue failures

[joth, 2012-12-23 23:58:50]

On 2012/12/22 03:01:58, kristianm1 wrote:
> lgtm
> 
> I was wondering if the destructor will be on the UI thread as well. Could
maybe
> add a DCHECK?
>

Good spot. The destructor  threading  was a bit ad-hoc. Fixed.

Thanks!

>
https://codereview.chromium.org/11661013/diff/1/android_webview/java/src/org/...
> File
> android_webview/java/src/org/chromium/android_webview/AwHttpAuthHandler.java
> (right):
> 
>
https://codereview.chromium.org/11661013/diff/1/android_webview/java/src/org/...
>
android_webview/java/src/org/chromium/android_webview/AwHttpAuthHandler.java:17:
> if (mNativeAwHttpAuthHandler != 0) {
> On 2012/12/22 02:55:16, joth wrote:
> > On 2012/12/22 02:39:04, kristianm1 wrote:
> > > Use null in Java
> > 
> > won't compile: it's an int. (native ptr)
> 
> Oh right, and it is just temporary stored here. Sorry about that, just looked
> weird in Java code.

[commit-bot: I haz the power, 2012-12-26 18:34:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joth@chromium.org/11661013/7002

[commit-bot: I haz the power, 2012-12-26 21:39:24]

Change committed as 174633