Tell java side when the native auth handler is gone

android_webview/native/aw_http_auth_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/native/aw_http_auth_handler.h"
 
 #include "android_webview/browser/aw_login_delegate.h"
 #include "android_webview/native/aw_contents.h"
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
+#include "content/public/browser/browser_thread.h"
 #include "jni/AwHttpAuthHandler_jni.h"
 #include "net/base/auth.h"
 #include "content/public/browser/web_contents.h"
 
 using base::android::ConvertJavaStringToUTF16;
 
 namespace android_webview {
 
 AwHttpAuthHandler::AwHttpAuthHandler(AwLoginDelegate* login_delegate,
                                      net::AuthChallengeInfo* auth_info,
                                      bool first_auth_attempt)
-    : login_delegate_(make_scoped_refptr(login_delegate)),
+    : login_delegate_(login_delegate),
       host_(auth_info->challenger.host()),
       realm_(auth_info->realm) {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   JNIEnv* env = base::android::AttachCurrentThread();
   http_auth_handler_.Reset(
       Java_AwHttpAuthHandler_create(
           env, reinterpret_cast<jint>(this), first_auth_attempt));
 }
 
 AwHttpAuthHandler:: ~AwHttpAuthHandler() {
-  // TODO(joth): tell java counterpart, so it can null its native back-pointer.
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+  Java_AwHttpAuthHandler_handlerDestroyed(base::android::AttachCurrentThread(),
+                                          http_auth_handler_.obj());
 }
 
 void AwHttpAuthHandler::Proceed(JNIEnv* env,
                                 jobject obj,
                                 jstring user,
                                 jstring password) {
-  login_delegate_->Proceed(ConvertJavaStringToUTF16(env, user),
-                           ConvertJavaStringToUTF16(env, password));
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+  if (login_delegate_) {
+    login_delegate_->Proceed(ConvertJavaStringToUTF16(env, user),
+                             ConvertJavaStringToUTF16(env, password));
+    login_delegate_ = NULL;
+  }
 }
 
 void AwHttpAuthHandler::Cancel(JNIEnv* env, jobject obj) {
-  login_delegate_->Cancel();
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+  if (login_delegate_) {
+    login_delegate_->Cancel();
+    login_delegate_ = NULL;
+  }
 }
 
 void AwHttpAuthHandler::HandleOnUIThread(content::WebContents* web_contents) {
   DCHECK(web_contents);
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   AwContents* aw_contents = AwContents::FromWebContents(web_contents);
 
   aw_contents->onReceivedHttpAuthRequest(
       http_auth_handler_, host_, realm_);
 }
 
 // static
 AwHttpAuthHandlerBase* AwHttpAuthHandlerBase::Create(
     AwLoginDelegate* login_delegate,
     net::AuthChallengeInfo* auth_info,
     bool first_auth_attempt) {
   return new AwHttpAuthHandler(login_delegate, auth_info, first_auth_attempt);
 }
 
 bool RegisterAwHttpAuthHandler(JNIEnv* env) {
   return RegisterNativesImpl(env) >= 0;
 }
 
 }  // namespace android_webview