Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: runtime/bin/run_vm_tests.cc

Issue 11660011: Clean up CodeObservers (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add a period to a comment. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/main.cc ('k') | runtime/vm/code_observers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/run_vm_tests.cc
diff --git a/runtime/bin/run_vm_tests.cc b/runtime/bin/run_vm_tests.cc
index c9173a88ea61e77b0a502db65ef8c0aeab2e04f6..c4d191e61562e9e475b0ee5e4166704cd1ed1796 100644
--- a/runtime/bin/run_vm_tests.cc
+++ b/runtime/bin/run_vm_tests.cc
@@ -59,29 +59,6 @@ void Benchmark::RunBenchmark() {
}
-static void DumpPprofSymbolInfo(const char* pprof_filename) {
- if (pprof_filename != NULL) {
- char* err = NULL;
- Dart_Isolate isolate = Dart_CreateIsolate(NULL, NULL, NULL, NULL, &err);
- EXPECT(isolate != NULL);
- Dart_EnterScope();
- File* pprof_file =
- File::Open(pprof_filename, File::kWriteTruncate);
- ASSERT(pprof_file != NULL);
- void* buffer;
- int buffer_size;
- Dart_GetPprofSymbolInfo(&buffer, &buffer_size);
- if (buffer_size > 0) {
- ASSERT(buffer != NULL);
- pprof_file->WriteFully(buffer, buffer_size);
- }
- delete pprof_file; // Closes the file.
- Dart_ExitScope();
- Dart_ShutdownIsolate();
- }
-}
-
-
static void PrintUsage() {
fprintf(stderr, "run_vm_tests [--list | --benchmarks | "
"--tests | --all | <test name> | <benchmark name>]\n");
@@ -94,7 +71,6 @@ static int Main(int argc, const char** argv) {
// Flags being passed to the Dart VM.
int dart_argc = 0;
const char** dart_argv = NULL;
- const char* pprof_filename = NULL;
if (argc < 2) {
// Bad parameter count.
@@ -119,21 +95,10 @@ static int Main(int argc, const char** argv) {
} else {
// Last argument is the test name, the rest are vm flags.
run_filter = argv[argc - 1];
- const char* pprof_option = "--generate_pprof_symbols=";
- int length = strlen(pprof_option);
- if (strncmp(pprof_option, argv[1], length) == 0) {
- pprof_filename = (argv[1] + length);
- Dart_InitPprofSupport();
- // Remove the first two values (executable, pprof flag) from the
- // arguments and exclude the last argument which is the test name.
- dart_argc = argc - 3;
- dart_argv = &argv[2];
- } else {
- // Remove the first value (executable) from the arguments and
- // exclude the last argument which is the test name.
- dart_argc = argc - 2;
- dart_argv = &argv[1];
- }
+ // Remove the first value (executable) from the arguments and
+ // exclude the last argument which is the test name.
+ dart_argc = argc - 2;
+ dart_argv = &argv[1];
}
bool set_vm_flags_success = Flags::ProcessCommandLineFlags(dart_argc,
dart_argv);
@@ -150,8 +115,6 @@ static int Main(int argc, const char** argv) {
fprintf(stderr, "No tests matched: %s\n", run_filter);
return 1;
}
- // Dump symbol information for the profiler.
- DumpPprofSymbolInfo(pprof_filename);
return 0;
}
« no previous file with comments | « runtime/bin/main.cc ('k') | runtime/vm/code_observers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698