Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: runtime/bin/main.cc

Issue 11660011: Clean up CodeObservers (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add a period to a comment. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/run_vm_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/main.cc
diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc
index 11093559a3884afd84a3a50f4de64c52934dfb04..35e68e39ab61db0ea2dbaa0a49a280c8d3f5a5bc 100644
--- a/runtime/bin/main.cc
+++ b/runtime/bin/main.cc
@@ -26,10 +26,6 @@
// it is initialized to NULL.
extern const uint8_t* snapshot_buffer;
-// Global state that indicates whether pprof symbol information is
-// to be generated or not.
-static const char* generate_pprof_symbols_filename = NULL;
-
// Global state that stores a pointer to the application script snapshot.
static bool use_script_snapshot = false;
@@ -147,12 +143,6 @@ static bool ProcessDebugOption(const char* port) {
return true;
}
-static bool ProcessPprofOption(const char* filename) {
- ASSERT(filename != NULL);
- generate_pprof_symbols_filename = filename;
- return true;
-}
-
static bool ProcessScriptSnapshotOption(const char* filename) {
if (filename != NULL && strlen(filename) != 0) {
@@ -179,7 +169,6 @@ static struct {
{ "--break_at=", ProcessBreakpointOption },
{ "--compile_all", ProcessCompileAllOption },
{ "--debug", ProcessDebugOption },
- { "--generate_pprof_symbols=", ProcessPprofOption },
{ "--use_script_snapshot=", ProcessScriptSnapshotOption },
{ NULL, NULL }
};
@@ -276,9 +265,6 @@ static int ParseArguments(int argc,
}
}
- if (generate_pprof_symbols_filename != NULL) {
- Dart_InitPprofSupport();
- }
// Get the script name.
if (i < argc) {
@@ -373,25 +359,6 @@ static Dart_Handle SetupRuntimeOptions(CommandLineOptions* options,
}
-static void DumpPprofSymbolInfo() {
- if (generate_pprof_symbols_filename != NULL) {
- Dart_EnterScope();
- File* pprof_file =
- File::Open(generate_pprof_symbols_filename, File::kWriteTruncate);
- ASSERT(pprof_file != NULL);
- void* buffer;
- int buffer_size;
- Dart_GetPprofSymbolInfo(&buffer, &buffer_size);
- if (buffer_size > 0) {
- ASSERT(buffer != NULL);
- pprof_file->WriteFully(buffer, buffer_size);
- }
- delete pprof_file; // Closes the file.
- Dart_ExitScope();
- }
-}
-
-
#define CHECK_RESULT(result) \
if (Dart_IsError(result)) { \
*error = strdup(Dart_GetError(result)); \
@@ -749,8 +716,6 @@ int main(int argc, char** argv) {
}
Dart_ExitScope();
- // Dump symbol information for the profiler.
- DumpPprofSymbolInfo();
// Shutdown the isolate.
Dart_ShutdownIsolate();
// Terminate process exit-code handler.
« no previous file with comments | « no previous file | runtime/bin/run_vm_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698