Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 11660007: Ignore exit-code of DRT and only trust stdout (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index aa9980a5d1b7f48555816a12d43064349da6c23b..b864d414fe21e3fe05ef9778e37ae31c1cf3b58c 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -707,7 +707,13 @@ class BrowserCommandOutputImpl extends CommandOutputImpl {
print("Warning: All tests passed, but exitCode != 0 "
"(${testCase.displayName})");
}
- return (exitCode != 0 && !hasCrashed);
+ if (testCase.configuration['runtime'] == 'drt') {
+ // TODO(kustermann/ricow): Issue: 7563
+ // We should eventually get rid of this hack.
+ return false;
+ } else {
+ return (exitCode != 0 && !hasCrashed);
+ }
}
break;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698