Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 11660007: Ignore exit-code of DRT and only trust stdout (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 689 matching lines...) Expand 10 before | Expand all | Expand 10 after
700 switch (line) { 700 switch (line) {
701 case 'Content-Type: text/plain': 701 case 'Content-Type: text/plain':
702 has_content_type = true; 702 has_content_type = true;
703 break; 703 break;
704 case 'PASS': 704 case 'PASS':
705 if (has_content_type) { 705 if (has_content_type) {
706 if (exitCode != 0) { 706 if (exitCode != 0) {
707 print("Warning: All tests passed, but exitCode != 0 " 707 print("Warning: All tests passed, but exitCode != 0 "
708 "(${testCase.displayName})"); 708 "(${testCase.displayName})");
709 } 709 }
710 return (exitCode != 0 && !hasCrashed); 710 if (testCase.configuration['runtime'] == 'drt') {
711 // TODO(kustermann/ricow): Issue: 7563
712 // We should eventually get rid of this hack.
713 return false;
714 } else {
715 return (exitCode != 0 && !hasCrashed);
716 }
711 } 717 }
712 break; 718 break;
713 } 719 }
714 } 720 }
715 return true; 721 return true;
716 } 722 }
717 } 723 }
718 724
719 // The static analyzer does not actually execute code, so 725 // The static analyzer does not actually execute code, so
720 // the criteria for success now depend on the text sent 726 // the criteria for success now depend on the text sent
(...skipping 1009 matching lines...) Expand 10 before | Expand all | Expand 10 after
1730 // the developer doesn't waste his or her time trying to fix a bunch of 1736 // the developer doesn't waste his or her time trying to fix a bunch of
1731 // tests that appear to be broken but were actually just flakes that 1737 // tests that appear to be broken but were actually just flakes that
1732 // didn't get retried because there had already been one failure. 1738 // didn't get retried because there had already been one failure.
1733 bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests; 1739 bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
1734 new RunningProcess(test, allowRetry, this).start(); 1740 new RunningProcess(test, allowRetry, this).start();
1735 } 1741 }
1736 _numProcesses++; 1742 _numProcesses++;
1737 } 1743 }
1738 } 1744 }
1739 } 1745 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698