extensions/browser/api/storage/storage_frontend.h - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/storage/storage_frontend.h

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finish renaming profile -> context Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/storage/storage_frontend.h

diff --git a/extensions/browser/api/storage/storage_frontend.h b/extensions/browser/api/storage/storage_frontend.h

index 5e11b82524e8490ec420a3ca9de66d158ba89da6..f1c82874479b5ec0a3fe81dc637a34d21492baa7 100644

--- a/extensions/browser/api/storage/storage_frontend.h

+++ b/extensions/browser/api/storage/storage_frontend.h

@@ -28,8 +28,8 @@ class StorageFrontend : public BrowserContextKeyedAPI {

// Returns the current instance for |context|.

static StorageFrontend* Get(content::BrowserContext* context);

- // Creates with a specific |storage_factory|. Caller owns the object.

- static StorageFrontend* CreateForTesting(

+ // Creates with a specific |storage_factory|.

+ static scoped_ptr<StorageFrontend> CreateForTesting(

const scoped_refptr<SettingsStorageFactory>& storage_factory,

content::BrowserContext* context);

« no previous file with comments | « extensions/browser/api/storage/storage_api_unittest.cc ('k') | extensions/browser/api/storage/storage_frontend.cc » ('j') | no next file with comments »