extensions/browser/api/storage/storage_frontend.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/storage/storage_frontend.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finish renaming profile -> context Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/storage/storage_frontend.h ('k') | extensions/browser/api/storage/storage_frontend_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/storage/storage_frontend.cc

diff --git a/extensions/browser/api/storage/storage_frontend.cc b/extensions/browser/api/storage/storage_frontend.cc

index e94ecd82d17af40aaa8045c629297d88660a6fac..dccd5e1179382e93b734df1fd49dc4e65876aaaa 100644

--- a/extensions/browser/api/storage/storage_frontend.cc

+++ b/extensions/browser/api/storage/storage_frontend.cc

@@ -65,10 +65,10 @@ StorageFrontend* StorageFrontend::Get(BrowserContext* context) {

}

// static

-StorageFrontend* StorageFrontend::CreateForTesting(

+scoped_ptr<StorageFrontend> StorageFrontend::CreateForTesting(

const scoped_refptr<SettingsStorageFactory>& storage_factory,

BrowserContext* context) {

- return new StorageFrontend(storage_factory, context);

+ return make_scoped_ptr(new StorageFrontend(storage_factory, context));

}

StorageFrontend::StorageFrontend(BrowserContext* context)

« no previous file with comments | « extensions/browser/api/storage/storage_frontend.h ('k') | extensions/browser/api/storage/storage_frontend_unittest.cc » ('j') | no next file with comments »