Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Unified Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsVariableBase.java

Issue 11659028: Rename JsVariableImpl -> JsVariableBase (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: clean Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsVariableBase.java
diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsVariableImpl.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsVariableBase.java
similarity index 90%
rename from plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsVariableImpl.java
rename to plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsVariableBase.java
index 3b0af565114c88ed3ae984cc9467c11814bc3745..c7e9abaae7526c3002ae5996cc8c7b369aa8ce40 100644
--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsVariableImpl.java
+++ b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsVariableBase.java
@@ -16,9 +16,8 @@ import org.chromium.sdk.SyncCallback;
/**
* A generic implementation of the JsVariable interface.
- * TODO(TBR-robot): rename into JsVariableBase
*/
-public abstract class JsVariableImpl implements JsVariable {
+public abstract class JsVariableBase implements JsVariable {
/** The lazily constructed value of this variable. */
private final JsValueBase value;
@@ -33,7 +32,7 @@ public abstract class JsVariableImpl implements JsVariable {
* @param valueLoader that owns this variable
* @param valueData for this variable
*/
- public JsVariableImpl(ValueLoader valueLoader, ValueMirror valueData, Object rawName) {
+ public JsVariableBase(ValueLoader valueLoader, ValueMirror valueData, Object rawName) {
this.rawName = rawName;
this.value = createValue(valueLoader, valueData);
}
@@ -107,7 +106,7 @@ public abstract class JsVariableImpl implements JsVariable {
/**
* A non-abstract class that implements JsVariable.
*/
- public static class Impl extends JsVariableImpl {
+ public static class Impl extends JsVariableBase {
public Impl(ValueLoader valueLoader, ValueMirror valueData, Object rawName) {
super(valueLoader, valueData, rawName);
}
@@ -118,10 +117,11 @@ public abstract class JsVariableImpl implements JsVariable {
}
/**
- * An extension to {@JsVariableImpl} that additional provides {@link JsObjectProperty} interface.
+ * An extension to {@link JsVariableBase} that additional provides {@link JsObjectProperty}
+ * interface.
* TODO: properly support getters, setters etc. once supported by protocol.
*/
- static class Property extends JsVariableImpl implements JsObjectProperty {
+ static class Property extends JsVariableBase implements JsObjectProperty {
public Property(ValueLoader valueLoader, ValueMirror valueData, Object rawName) {
super(valueLoader, valueData, rawName);
}

Powered by Google App Engine
This is Rietveld 408576698