plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java - Issue 11659028: Rename JsVariableImpl -> JsVariableBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java

Issue 11659028: Rename JsVariableImpl -> JsVariableBase (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk

Patch Set: clean Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsObjectBase.java ('k') | plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsVariableBase.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java

diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java

index e6eaf4c885c683097dc5e076d8b05b0fe13fe95f..7062dee2e0a4a5614476d50cb3d0ec5bc67af969 100644

--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java

+++ b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java

@@ -184,7 +184,7 @@ public abstract class JsScopeImpl<D> implements JsScope {

for (int i = 0; i < propertyMirrors.size(); i++) {

// This name should be string. We are making it string as a fall-back strategy.

String varNameStr = propertyRefs.get(i).getName().toString();

- properties.add(new JsVariableImpl.Impl(valueLoader, propertyMirrors.get(i), varNameStr));

+ properties.add(new JsVariableBase.Impl(valueLoader, propertyMirrors.get(i), varNameStr));

}

return properties;

}

@@ -230,7 +230,7 @@ public abstract class JsScopeImpl<D> implements JsScope {

throws MethodIsBlockingException {

ObjectValueHandle scopeObject = loadScopeObject(valueLoader);

ValueMirror mirror = valueLoader.addDataToMap(scopeObject.getSuper());

- JsValue jsValue = JsVariableImpl.createValue(valueLoader, mirror);

+ JsValue jsValue = JsVariableBase.createValue(valueLoader, mirror);

return new DeferredData(jsValue, cacheState);

}