plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/ExceptionDataImpl.java - Issue 11659028: Rename JsVariableImpl -> JsVariableBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/ExceptionDataImpl.java

Issue 11659028: Rename JsVariableImpl -> JsVariableBase (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk

Patch Set: clean Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/JsEvaluateContextImpl.java ('k') | plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsArrayImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/ExceptionDataImpl.java

diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/ExceptionDataImpl.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/ExceptionDataImpl.java

index 4bf5f2ea3f7fe5fcca7cb3bad1f32046bb0a815f..965e5611285e14dbc97ea5742aa794ae513ba0c6 100755

--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/ExceptionDataImpl.java

+++ b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/ExceptionDataImpl.java

@@ -35,7 +35,7 @@ public class ExceptionDataImpl implements ExceptionData {

public JsValue getExceptionValue() {

if (cachedException == null) {

// TODO: make it thread-safe.

- cachedException = JsVariableImpl.createValue(context.getValueLoader(), mirror);

+ cachedException = JsVariableBase.createValue(context.getValueLoader(), mirror);

}

return cachedException;

}