plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/JsEvaluateContextImpl.java - Issue 11659028: Rename JsVariableImpl -> JsVariableBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/JsEvaluateContextImpl.java

Issue 11659028: Rename JsVariableImpl -> JsVariableBase (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk

Patch Set: clean Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/CallFrameImpl.java ('k') | plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/ExceptionDataImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/JsEvaluateContextImpl.java

diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/JsEvaluateContextImpl.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/JsEvaluateContextImpl.java

index afa425402388adef3dbb48938bd49259af420fd8..19a9c5841f3ee344a87e76a80ef599f1b1a2cd8c 100644

--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/JsEvaluateContextImpl.java

+++ b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/JsEvaluateContextImpl.java

@@ -23,7 +23,7 @@ import org.chromium.sdk.internal.v8native.protocol.output.DebuggerMessage;

import org.chromium.sdk.internal.v8native.protocol.output.DebuggerMessageFactory;

import org.chromium.sdk.internal.v8native.protocol.output.EvaluateMessage;

import org.chromium.sdk.internal.v8native.value.JsValueBase;

-import org.chromium.sdk.internal.v8native.value.JsVariableImpl;

+import org.chromium.sdk.internal.v8native.value.JsVariableBase;

import org.chromium.sdk.internal.v8native.value.ValueMirror;

import org.chromium.sdk.util.RelaySyncCallback;

import org.json.simple.JSONValue;

@@ -61,7 +61,7 @@ abstract class JsEvaluateContextImpl extends JsEvaluateContextBase {

InternalContext internalContext = getInternalContext();

ValueMirror mirror = internalContext.getValueLoader().addDataToMap(body);

final JsValue value =

- JsVariableImpl.createValue(internalContext.getValueLoader(), mirror);

+ JsVariableBase.createValue(internalContext.getValueLoader(), mirror);

ResultOrException result = new ResultOrException() {

@Override public JsValue getResult() {

return value;