Teach ninja to handle output directories outside the source dir.

Teach ninja to handle output directories outside the source dir.

Currently, ninja only works when the output directory is a subdirectory
of the source dir, and all of the tests that test this behavior are disabled
for ninja. This patch fixes ninja to calculate the path to the output
directory correctly even when it is in a different location.

To test this bug fix, I've re-enabled six tests that test this behavior.
These tests all fail prior to this change. I've also added a new test for
symlinks.

BUG=gyp:314
TEST=Run all unit tests. Test full builds of Chrome using ninja and make
     on several platforms.

[davidjames, 2012-12-21 06:07:51]

PTAL. The patch from gutschke@ didn't work for me because it assumes that
toplevel_dir is '.' -- i.e., the paths passed into InvertRelativePath are
relative to the current directory. This isn't necessarily true.

I've added tests to cover my use case.

[Nico, 2012-12-21 22:52:08]

Nice! lgtm

I'm not a fan of the CL description though. The tests that you reenabled are
for --generator-output, which ninja used to not support as it doesn't
really make sense for ninja. --generator-output describes where Makefiles
are produced, while ninja supports -Goutput_dir which describes where build
output goes, and ninja always writes its "makefiles" into the build output
directory. To make gyp more self-consistent, --generator-output in ninja
now is just the directory that -Goutput_directory is relative to, so I'd word
the
description like

   "Also enable the --generator-output tests after rXXX (with XXX being the
revision where the support was added) which test for this behavior."

Evan, do you know a reason why this wasn't supported?


Sorry for the delayed review. I'll land this for you soon.

https://codereview.chromium.org/11659002/diff/6001/pylib/gyp/common.py
File pylib/gyp/common.py (right):

https://codereview.chromium.org/11659002/diff/6001/pylib/gyp/common.py#newcod...
pylib/gyp/common.py:130: # Convert to absolute (and therefore normalized paths).
Is the comment now out of date?

https://codereview.chromium.org/11659002/diff/6001/test/generator-output/gypt...
File test/generator-output/gyptest-relocate.py (right):

https://codereview.chromium.org/11659002/diff/6001/test/generator-output/gypt...
test/generator-output/gyptest-relocate.py:14: # Ninja and Android don't support
--generator-output.
comment

[Nico, 2012-12-26 16:50:08]

Landed with minor comment tweaks in r1555.