Chromium Code Reviews
Help | Chromium Project | Sign in
(59)

Issue 11659002: Teach ninja to handle output directories outside the source dir. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by davidjames
Modified:
2 years, 1 month ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com, Evan Martin
Visibility:
Public.

Description

Teach ninja to handle output directories outside the source dir. Currently, ninja only works when the output directory is a subdirectory of the source dir, and all of the tests that test this behavior are disabled for ninja. This patch fixes ninja to calculate the path to the output directory correctly even when it is in a different location. To test this bug fix, I've re-enabled six tests that test this behavior. These tests all fail prior to this change. I've also added a new test for symlinks. BUG=gyp:314 TEST=Run all unit tests. Test full builds of Chrome using ninja and make on several platforms.

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -54 lines) Patch
M pylib/gyp/common.py View 2 chunks +16 lines, -2 lines 1 comment Download
M pylib/gyp/generator/make.py View 2 chunks +1 line, -16 lines 0 comments Download
M pylib/gyp/generator/ninja.py View 6 chunks +13 lines, -22 lines 0 comments Download
M test/builddir/gyptest-all.py View 1 chunk +1 line, -0 lines 0 comments Download
M test/builddir/gyptest-default.py View 1 chunk +1 line, -0 lines 0 comments Download
M test/generator-output/gyptest-actions.py View 1 chunk +2 lines, -2 lines 0 comments Download
M test/generator-output/gyptest-copies.py View 1 chunk +2 lines, -1 line 0 comments Download
M test/generator-output/gyptest-mac-bundle.py View 1 chunk +1 line, -2 lines 0 comments Download
M test/generator-output/gyptest-relocate.py View 1 chunk +1 line, -1 line 1 comment Download
M test/generator-output/gyptest-rules.py View 1 chunk +2 lines, -2 lines 0 comments Download
M test/generator-output/gyptest-subdir2-deep.py View 1 chunk +2 lines, -2 lines 0 comments Download
A test/generator-output/gyptest-symlink.py View 1 1 chunk +43 lines, -0 lines 0 comments Download
M test/generator-output/gyptest-top-all.py View 1 chunk +2 lines, -2 lines 0 comments Download
M test/subdirectory/gyptest-subdir-all.py View 1 chunk +2 lines, -1 line 0 comments Download
M test/subdirectory/gyptest-subdir-default.py View 1 chunk +2 lines, -1 line 0 comments Download
Commit:

Messages

Total messages: 3 (0 generated)
davidjames
PTAL. The patch from gutschke@ didn't work for me because it assumes that toplevel_dir is ...
2 years, 2 months ago (2012-12-21 06:07:51 UTC) #1
Nico
Nice! lgtm I'm not a fan of the CL description though. The tests that you ...
2 years, 2 months ago (2012-12-21 22:52:08 UTC) #2
Nico
2 years, 2 months ago (2012-12-26 16:50:08 UTC) #3
Message was sent while issue was closed.
Landed with minor comment tweaks in r1555.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld dd99357-tainted