Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2521)

Unified Diff: Source/platform/PartitionAllocMemoryDumpProvider.cpp

Issue 1165703010: PartitionAlloc: improve how statistics appear in chrome://tracing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: git cl try Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/wtf/PartitionAlloc.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/PartitionAllocMemoryDumpProvider.cpp
diff --git a/Source/platform/PartitionAllocMemoryDumpProvider.cpp b/Source/platform/PartitionAllocMemoryDumpProvider.cpp
index 9e5ac8f6ce5bf9401373c83b679829f0a385817c..08b151ae82783ed86162a5902e9f2182b18e7788 100644
--- a/Source/platform/PartitionAllocMemoryDumpProvider.cpp
+++ b/Source/platform/PartitionAllocMemoryDumpProvider.cpp
@@ -42,13 +42,15 @@ void PartitionStatsDumperImpl::partitionsDumpBucketStats(const char* partitionNa
WebMemoryAllocatorDump* allocatorDump = m_memoryDump->createMemoryAllocatorDump(dumpName);
allocatorDump->AddScalar("size", "bytes", memoryStats->residentBytes);
- allocatorDump->AddScalar("waste_size", "bytes", memoryStats->pageWasteSize);
- allocatorDump->AddScalar("partition_page_size", "bytes", memoryStats->allocatedPageSize);
- allocatorDump->AddScalar("freeable_size", "bytes", memoryStats->freeableBytes);
- allocatorDump->AddScalar("full_partition_pages", "objects", memoryStats->numFullPages);
- allocatorDump->AddScalar("active_partition_pages", "objects", memoryStats->numActivePages);
- allocatorDump->AddScalar("empty_partition_pages", "objects", memoryStats->numEmptyPages);
- allocatorDump->AddScalar("decommitted_partition_pages", "objects", memoryStats->numDecommittedPages);
+ allocatorDump->AddScalar("0slot_size", "bytes", memoryStats->bucketSlotSize);
Primiano Tucci (use gerrit) 2015/06/06 16:00:37 Hmmm I see that you want to enforce ordering and u
+ allocatorDump->AddScalar("1active_size", "bytes", memoryStats->activeBytes);
+ allocatorDump->AddScalar("2resident_size", "bytes", memoryStats->residentBytes);
+ allocatorDump->AddScalar("3freeable_size", "bytes", memoryStats->freeableBytes);
+ allocatorDump->AddScalar("4num_active", "objects", memoryStats->numActivePages);
+ allocatorDump->AddScalar("5num_full", "objects", memoryStats->numFullPages);
+ allocatorDump->AddScalar("6num_empty", "objects", memoryStats->numEmptyPages);
+ allocatorDump->AddScalar("7num_decommitted", "objects", memoryStats->numDecommittedPages);
+ allocatorDump->AddScalar("8page_size", "bytes", memoryStats->allocatedPageSize);
dumpName = dumpName + "/allocated_objects";
WebMemoryAllocatorDump* objectsDump = m_memoryDump->createMemoryAllocatorDump(dumpName);
« no previous file with comments | « no previous file | Source/wtf/PartitionAlloc.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698