PartitionAlloc: improve how statistics appear in chrome://tracing.

Source/platform/PartitionAllocMemoryDumpProvider.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "Source/platform/PartitionAllocMemoryDumpProvider.h"
 
 #include "public/platform/WebMemoryAllocatorDump.h"
 #include "public/platform/WebProcessMemoryDump.h"
 #include "wtf/Partitions.h"
@@ skipping 24 matching lines @@
 {
     ASSERT(memoryStats->isValid);
     String dumpName;
     if (memoryStats->isDirectMap)
         dumpName = String::format("partition_alloc/%s/directMap_%zu", partitionName, ++m_uid);
     else
         dumpName = String::format("partition_alloc/%s/bucket_%zu", partitionName, static_cast<size_t>(memoryStats->bucketSlotSize));
 
     WebMemoryAllocatorDump* allocatorDump = m_memoryDump->createMemoryAllocatorDump(dumpName);
     allocatorDump->AddScalar("size", "bytes", memoryStats->residentBytes);
-    allocatorDump->AddScalar("waste_size", "bytes", memoryStats->pageWasteSize);
-    allocatorDump->AddScalar("partition_page_size", "bytes", memoryStats->allocatedPageSize);
-    allocatorDump->AddScalar("freeable_size", "bytes", memoryStats->freeableBytes);
-    allocatorDump->AddScalar("full_partition_pages", "objects", memoryStats->numFullPages);
-    allocatorDump->AddScalar("active_partition_pages", "objects", memoryStats->numActivePages);
-    allocatorDump->AddScalar("empty_partition_pages", "objects", memoryStats->numEmptyPages);
-    allocatorDump->AddScalar("decommitted_partition_pages", "objects", memoryStats->numDecommittedPages);
+    allocatorDump->AddScalar("0slot_size", "bytes", memoryStats->bucketSlotSize);

[Primiano Tucci (use gerrit), 2015/06/06 16:00:37]

Hmmm I see that you want to enforce ordering and unfortunately today we don't
have a way to express it, but this IMHO looks too much of a hack.
How about we do the hack in the UI (say: sort by (column.name contains "size",
column.name) until we have a better way to express ordering here? (so this would
work also for the upcoming oilpan dumper)

+    allocatorDump->AddScalar("1active_size", "bytes", memoryStats->activeBytes);
+    allocatorDump->AddScalar("2resident_size", "bytes", memoryStats->residentBytes);
+    allocatorDump->AddScalar("3freeable_size", "bytes", memoryStats->freeableBytes);
+    allocatorDump->AddScalar("4num_active", "objects", memoryStats->numActivePages);
+    allocatorDump->AddScalar("5num_full", "objects", memoryStats->numFullPages);
+    allocatorDump->AddScalar("6num_empty", "objects", memoryStats->numEmptyPages);
+    allocatorDump->AddScalar("7num_decommitted", "objects", memoryStats->numDecommittedPages);
+    allocatorDump->AddScalar("8page_size", "bytes", memoryStats->allocatedPageSize);
 
     dumpName = dumpName + "/allocated_objects";
     WebMemoryAllocatorDump* objectsDump = m_memoryDump->createMemoryAllocatorDump(dumpName);
     objectsDump->AddScalar("size", "bytes", memoryStats->activeBytes);
 }
 
 } // namespace
 
 PartitionAllocMemoryDumpProvider* PartitionAllocMemoryDumpProvider::instance()
 {
@@ skipping 12 matching lines @@
 
 PartitionAllocMemoryDumpProvider::PartitionAllocMemoryDumpProvider()
 {
 }
 
 PartitionAllocMemoryDumpProvider::~PartitionAllocMemoryDumpProvider()
 {
 }
 
 } // namespace blink