Issue 1165553011: [chromedriver] Update NavigationTracker state after Page.navigationToHistoryEntry commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1165553011: [chromedriver] Update NavigationTracker state after Page.navigationToHistoryEntry commands. (Closed)

Created:
5 years, 6 months ago by samuong

Modified:
5 years, 6 months ago

Reviewers:

CC:
chromium-reviews, samuong+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[chromedriver] Update NavigationTracker state after Page.navigationToHistoryEntry commands. BUG=chromedriver:1118 TBR=stgao@chromium.org Committed: https://crrev.com/038d10687396bcfca2361fa1f44189ccea0651b1 Cr-Commit-Position: refs/heads/master@{#333184}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/test/chromedriver/chrome/navigation_tracker.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/test/data/chromedriver/outer.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (1 generated)

samuong

TBR'ing so that testSwitchesToTopFrameAfterGoingBack stops flaking out on the bots.

5 years, 6 months ago (2015-06-05 23:15:26 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165553011/1

5 years, 6 months ago (2015-06-05 23:17:25 UTC) #3

commit-bot: I haz the power

5 years, 6 months ago (2015-06-06 00:24:55 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/038d10687396bcfca2361fa1f44189ccea0651b1
Cr-Commit-Position: refs/heads/master@{#333184}