Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8661)

Unified Diff: chrome/test/chromedriver/chrome/navigation_tracker.cc

Issue 1165553011: [chromedriver] Update NavigationTracker state after Page.navigationToHistoryEntry commands. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/chromedriver/outer.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/navigation_tracker.cc
diff --git a/chrome/test/chromedriver/chrome/navigation_tracker.cc b/chrome/test/chromedriver/chrome/navigation_tracker.cc
index ed9ad877d9fa98e9bfa44d9cf0992e7f82225511..540e83dfef38846d6ebd30c97abf0524efcc1043 100644
--- a/chrome/test/chromedriver/chrome/navigation_tracker.cc
+++ b/chrome/test/chromedriver/chrome/navigation_tracker.cc
@@ -181,7 +181,8 @@ Status NavigationTracker::OnEvent(DevToolsClient* client,
Status NavigationTracker::OnCommandSuccess(DevToolsClient* client,
const std::string& method) {
- if (method == "Page.navigate" && loading_state_ != kLoading) {
+ if ((method == "Page.navigate" || method == "Page.navigateToHistoryEntry") &&
+ loading_state_ != kLoading) {
// At this point the browser has initiated the navigation, but besides that,
// it is unknown what will happen.
//
« no previous file with comments | « no previous file | chrome/test/data/chromedriver/outer.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698