Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1165553008: Use SingleParameterFormatter for settings override permissions. (Closed)

Created:
5 years, 6 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 6 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SingleParameterFormatter for settings override permissions. The search provider, home page and start pages override permission messages each take a parameter describing the URL that the setting can be changed to. This was being properly handed in settings_override_permission.cc but not in the message formatters in chrome_permission_message_rules.cc. This change also removes the duplicate rules for these permissions. BUG=496332 Committed: https://crrev.com/c1f0c854d5c1ce20351d69a97f6538ed9acbd24c Cr-Commit-Position: refs/heads/master@{#333119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -20 lines) Patch
M chrome/common/extensions/permissions/chrome_permission_message_rules.cc View 3 chunks +10 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 6 months ago (2015-06-03 21:10:51 UTC) #2
Reilly Grant (use Gerrit)
Ping?
5 years, 6 months ago (2015-06-05 16:24:38 UTC) #3
Devlin
Sorry for the delay; lgtm.
5 years, 6 months ago (2015-06-05 17:34:54 UTC) #4
Reilly Grant (use Gerrit)
On 2015/06/05 17:34:54, Devlin wrote: > Sorry for the delay; lgtm. Thank you for the ...
5 years, 6 months ago (2015-06-05 18:02:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165553008/1
5 years, 6 months ago (2015-06-05 18:03:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 20:40:25 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 20:41:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1f0c854d5c1ce20351d69a97f6538ed9acbd24c
Cr-Commit-Position: refs/heads/master@{#333119}

Powered by Google App Engine
This is Rietveld 408576698