Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2553)

Unified Diff: chrome/common/extensions/permissions/chrome_permission_message_rules.cc

Issue 1165553008: Use SingleParameterFormatter for settings override permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/permissions/chrome_permission_message_rules.cc
diff --git a/chrome/common/extensions/permissions/chrome_permission_message_rules.cc b/chrome/common/extensions/permissions/chrome_permission_message_rules.cc
index 6b22aad000a35c3bd7af8eb3522fd4b6b6b9bb67..56b37685554fd72c9b49b3d4bc99f669694c4f21 100644
--- a/chrome/common/extensions/permissions/chrome_permission_message_rules.cc
+++ b/chrome/common/extensions/permissions/chrome_permission_message_rules.cc
@@ -302,6 +302,9 @@ ChromePermissionMessageRule::GetAllRules() {
IDS_EXTENSION_PROMPT_WARNING_USB_DEVICE_UNKNOWN_PRODUCT),
{APIPermission::kUsbDeviceUnknownProduct},
{}},
+ {IDS_EXTENSION_PROMPT_WARNING_USB_DEVICE_UNKNOWN_VENDOR,
+ {APIPermission::kUsbDeviceUnknownVendor},
+ {}},
{new SimpleListFormatter(IDS_EXTENSION_PROMPT_WARNING_USB_DEVICE_LIST),
{APIPermission::kUsbDeviceList},
{}},
@@ -535,17 +538,6 @@ ChromePermissionMessageRule::GetAllRules() {
{APIPermission::kInterceptAllKeys},
{}},
- // Settings override permission messages.
- {IDS_EXTENSION_PROMPT_WARNING_HOME_PAGE_SETTING_OVERRIDE,
- {APIPermission::kHomepage},
- {}},
- {IDS_EXTENSION_PROMPT_WARNING_SEARCH_SETTINGS_OVERRIDE,
- {APIPermission::kSearchProvider},
- {}},
- {IDS_EXTENSION_PROMPT_WARNING_START_PAGE_SETTING_OVERRIDE,
- {APIPermission::kStartupPages},
- {}},
-
{IDS_EXTENSION_PROMPT_WARNING_AUDIO_AND_VIDEO_CAPTURE,
{APIPermission::kAudioCapture, APIPermission::kVideoCapture},
{}},
@@ -595,19 +587,17 @@ ChromePermissionMessageRule::GetAllRules() {
// API permission rules:
// SettingsOverrideAPIPermission:
- {IDS_EXTENSION_PROMPT_WARNING_HOME_PAGE_SETTING_OVERRIDE,
+ {new SingleParameterFormatter(
+ IDS_EXTENSION_PROMPT_WARNING_HOME_PAGE_SETTING_OVERRIDE),
{APIPermission::kHomepage},
{}},
- {IDS_EXTENSION_PROMPT_WARNING_START_PAGE_SETTING_OVERRIDE,
- {APIPermission::kStartupPages},
- {}},
- {IDS_EXTENSION_PROMPT_WARNING_SEARCH_SETTINGS_OVERRIDE,
+ {new SingleParameterFormatter(
+ IDS_EXTENSION_PROMPT_WARNING_SEARCH_SETTINGS_OVERRIDE),
{APIPermission::kSearchProvider},
{}},
-
- // USBDevicePermission:
- {IDS_EXTENSION_PROMPT_WARNING_USB_DEVICE_UNKNOWN_VENDOR,
- {APIPermission::kUsbDeviceUnknownVendor},
+ {new SingleParameterFormatter(
+ IDS_EXTENSION_PROMPT_WARNING_START_PAGE_SETTING_OVERRIDE),
+ {APIPermission::kStartupPages},
{}},
// Other rules:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698