Fine tuning glGetInternalformativ.

Fine tuning glGetInternalformativ.

This is to make glRenderbufferStorageMultisample related tests working.

BUG=429053
TEST=gpu_unittests, newly added multisampled-renderbuffer-initialization.html
R=piman@chromium.org

Committed: https://crrev.com/335fe5410aba7d27d0890aeb68e77a4bba840ccd
Cr-Commit-Position: refs/heads/master@{#333152}

[Zhenyao Mo, 2015-05-29 18:53:25]

piman: PTAL
Others: FYI (feel free to review)

[piman, 2015-06-01 21:29:37]

https://codereview.chromium.org/1165553003/diff/20001/gpu/command_buffer/buil...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/1165553003/diff/20001/gpu/command_buffer/buil...
gpu/command_buffer/build_gles2_cmd_buffer.py:6311: """
I don't think this should belong to the generator. Can we make
GetInternalformativ a Custom or Manual type instead?

https://codereview.chromium.org/1165553003/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_autogen.h (right):

https://codereview.chromium.org/1165553003/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_autogen.h:1661:
glGetInternalformativ(target, format, GL_NUM_SAMPLE_COUNTS, 1, &value);
GL_NUM_SAMPLE_COUNTS is only involved if pname is GL_SAMPLES, but
GetInternalformativ could take other values (GL_NUM_SAMPLE_COUNTS is one).
I would prefer following that logic only in the GL_SAMPLES case.

I think the service-side logic would actually be easier if the service side
always decides the size of the returned buffer. No bufSize would be passed in
the command buffers. The GLES2Implementation would be doing the clamping of the
results. It's less prone to security issues.

[Zhenyao Mo, 2015-06-04 01:25:06]

Patchset #3 (id:40001) has been deleted

[Zhenyao Mo, 2015-06-04 01:27:06]

piman: switched to custom written command.  Please take another look.

[piman, 2015-06-05 20:59:22]

lgtm

[Zhenyao Mo, 2015-06-05 21:17:56]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2015-06-05 21:19:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1165553003/60001

[commit-bot: I haz the power, 2015-06-05 22:23:51]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-06-05 22:24:49]

Patchset 3 (id:??) landed as
https://crrev.com/335fe5410aba7d27d0890aeb68e77a4bba840ccd
Cr-Commit-Position: refs/heads/master@{#333152}