Fine tuning glGetInternalformativ.

gpu/command_buffer/service/gles2_cmd_decoder_autogen.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file is auto-generated from
 // gpu/command_buffer/build_gles2_cmd_buffer.py
 // It's formatted by clang-format using chromium coding style:
 //    clang-format -i -style=chromium filename
 // DO NOT EDIT!
 
@@ skipping 1363 matching lines @@
   }
   if (params == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetBooleanv");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   DoGetBooleanv(pname, params);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetBooleanv");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetBooleanv", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetBufferParameteriv(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   const gles2::cmds::GetBufferParameteriv& c =
       *static_cast<const gles2::cmds::GetBufferParameteriv*>(cmd_data);
   (void)c;
@@ skipping 57 matching lines @@
   }
   if (params == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetFloatv");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   DoGetFloatv(pname, params);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetFloatv");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetFloatv", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetFramebufferAttachmentParameteriv(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   const gles2::cmds::GetFramebufferAttachmentParameteriv& c =
       *static_cast<const gles2::cmds::GetFramebufferAttachmentParameteriv*>(
           cmd_data);
@@ skipping 24 matching lines @@
   }
   if (params == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetFramebufferAttachmentParameteriv");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   DoGetFramebufferAttachmentParameteriv(target, attachment, pname, params);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetFramebufferAttachmentParameteriv");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetFramebufferAttachmentParameteriv", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetInteger64v(uint32_t immediate_data_size,
                                                    const void* cmd_data) {
   if (!unsafe_es3_apis_enabled())
     return error::kUnknownCommand;
   const gles2::cmds::GetInteger64v& c =
       *static_cast<const gles2::cmds::GetInteger64v*>(cmd_data);
   (void)c;
   GLenum pname = static_cast<GLenum>(c.pname);
   typedef cmds::GetInteger64v::Result Result;
   GLsizei num_values = 0;
   GetNumValuesReturnedForGLGet(pname, &num_values);
   Result* result = GetSharedMemoryAs<Result*>(
       c.params_shm_id, c.params_shm_offset, Result::ComputeSize(num_values));
   GLint64* params = result ? result->GetData() : NULL;
   if (params == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetInteger64v");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   DoGetInteger64v(pname, params);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetInteger64v");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetInteger64v", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetIntegeri_v(uint32_t immediate_data_size,
                                                    const void* cmd_data) {
   if (!unsafe_es3_apis_enabled())
     return error::kUnknownCommand;
   const gles2::cmds::GetIntegeri_v& c =
       *static_cast<const gles2::cmds::GetIntegeri_v*>(cmd_data);
   (void)c;
   GLenum pname = static_cast<GLenum>(c.pname);
   GLuint index = static_cast<GLuint>(c.index);
   typedef cmds::GetIntegeri_v::Result Result;
   GLsizei num_values = 0;
   GetNumValuesReturnedForGLGet(pname, &num_values);
   Result* result = GetSharedMemoryAs<Result*>(c.data_shm_id, c.data_shm_offset,
                                               Result::ComputeSize(num_values));
   GLint* data = result ? result->GetData() : NULL;
   if (data == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetIntegeri_v");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   glGetIntegeri_v(pname, index, data);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetIntegeri_v");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetIntegeri_v", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetInteger64i_v(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   if (!unsafe_es3_apis_enabled())
     return error::kUnknownCommand;
   const gles2::cmds::GetInteger64i_v& c =
       *static_cast<const gles2::cmds::GetInteger64i_v*>(cmd_data);
   (void)c;
   GLenum pname = static_cast<GLenum>(c.pname);
   GLuint index = static_cast<GLuint>(c.index);
   typedef cmds::GetInteger64i_v::Result Result;
   GLsizei num_values = 0;
   GetNumValuesReturnedForGLGet(pname, &num_values);
   Result* result = GetSharedMemoryAs<Result*>(c.data_shm_id, c.data_shm_offset,
                                               Result::ComputeSize(num_values));
   GLint64* data = result ? result->GetData() : NULL;
   if (data == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetInteger64i_v");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   glGetInteger64i_v(pname, index, data);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetInteger64i_v");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetInteger64i_v", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetIntegerv(uint32_t immediate_data_size,
                                                  const void* cmd_data) {
   const gles2::cmds::GetIntegerv& c =
       *static_cast<const gles2::cmds::GetIntegerv*>(cmd_data);
   (void)c;
   GLenum pname = static_cast<GLenum>(c.pname);
   typedef cmds::GetIntegerv::Result Result;
   GLsizei num_values = 0;
   GetNumValuesReturnedForGLGet(pname, &num_values);
   Result* result = GetSharedMemoryAs<Result*>(
       c.params_shm_id, c.params_shm_offset, Result::ComputeSize(num_values));
   GLint* params = result ? result->GetData() : NULL;
   if (!validators_->g_l_state.IsValid(pname)) {
     LOCAL_SET_GL_ERROR_INVALID_ENUM("glGetIntegerv", pname, "pname");
     return error::kNoError;
   }
   if (params == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetIntegerv");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   DoGetIntegerv(pname, params);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetIntegerv");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetIntegerv", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetInternalformativ(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   if (!unsafe_es3_apis_enabled())
     return error::kUnknownCommand;
   const gles2::cmds::GetInternalformativ& c =
       *static_cast<const gles2::cmds::GetInternalformativ*>(cmd_data);
   (void)c;
   GLenum target = static_cast<GLenum>(c.target);
   GLenum format = static_cast<GLenum>(c.format);
   GLenum pname = static_cast<GLenum>(c.pname);
   GLsizei bufSize = static_cast<GLsizei>(c.bufSize);
   typedef cmds::GetInternalformativ::Result Result;
   GLsizei num_values = 0;
-  GetNumValuesReturnedForGLGet(pname, &num_values);
+  if (bufSize > 0) {
+    // Sanity check for |bufSize| and set its upbound.
+    GLint value = 0;
+    LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetInternalformativ");
+    glGetInternalformativ(target, format, GL_NUM_SAMPLE_COUNTS, 1, &value);

[piman, 2015/06/01 21:29:37]

GL_NUM_SAMPLE_COUNTS is only involved if pname is GL_SAMPLES, but
GetInternalformativ could take other values (GL_NUM_SAMPLE_COUNTS is one).
I would prefer following that logic only in the GL_SAMPLES case.

I think the service-side logic would actually be easier if the service side
always decides the size of the returned buffer. No bufSize would be passed in
the command buffers. The GLES2Implementation would be doing the clamping of the
results. It's less prone to security issues.

+    GLenum error = LOCAL_PEEK_GL_ERROR("GetInternalformativ");
+    if (error != GL_NO_ERROR) {
+      return error::kNoError;
+    }
+    if (value < bufSize) {
+      bufSize = value;
+    }
+  }
+
+  if (bufSize > 0) {
+    num_values = static_cast<GLsizei>(bufSize);
+  }
   Result* result = GetSharedMemoryAs<Result*>(
       c.params_shm_id, c.params_shm_offset, Result::ComputeSize(num_values));
   GLint* params = result ? result->GetData() : NULL;
   if (params == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetInternalformativ");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   glGetInternalformativ(target, format, pname, bufSize, params);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetInternalformativ");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetInternalformativ", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetProgramiv(uint32_t immediate_data_size,
                                                   const void* cmd_data) {
   const gles2::cmds::GetProgramiv& c =
       *static_cast<const gles2::cmds::GetProgramiv*>(cmd_data);
   (void)c;
   GLuint program = c.program;
@@ skipping 10 matching lines @@
   }
   if (params == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetProgramiv");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   DoGetProgramiv(program, pname, params);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetProgramiv");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetProgramiv", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetRenderbufferParameteriv(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   const gles2::cmds::GetRenderbufferParameteriv& c =
       *static_cast<const gles2::cmds::GetRenderbufferParameteriv*>(cmd_data);
   (void)c;
@@ skipping 17 matching lines @@
   }
   if (params == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetRenderbufferParameteriv");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   DoGetRenderbufferParameteriv(target, pname, params);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetRenderbufferParameteriv");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetRenderbufferParameteriv", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetSamplerParameterfv(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   if (!unsafe_es3_apis_enabled())
     return error::kUnknownCommand;
   const gles2::cmds::GetSamplerParameterfv& c =
@@ skipping 14 matching lines @@
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   if (!group_->GetSamplerServiceId(sampler, &sampler)) {
     LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, "glGetSamplerParameterfv",
                        "invalid sampler id");
     return error::kNoError;
   }
   glGetSamplerParameterfv(sampler, pname, params);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetSamplerParameterfv");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetSamplerParameterfv", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetSamplerParameteriv(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   if (!unsafe_es3_apis_enabled())
     return error::kUnknownCommand;
   const gles2::cmds::GetSamplerParameteriv& c =
@@ skipping 14 matching lines @@
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   if (!group_->GetSamplerServiceId(sampler, &sampler)) {
     LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, "glGetSamplerParameteriv",
                        "invalid sampler id");
     return error::kNoError;
   }
   glGetSamplerParameteriv(sampler, pname, params);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetSamplerParameteriv");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetSamplerParameteriv", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetShaderiv(uint32_t immediate_data_size,
                                                  const void* cmd_data) {
   const gles2::cmds::GetShaderiv& c =
       *static_cast<const gles2::cmds::GetShaderiv*>(cmd_data);
   (void)c;
   GLuint shader = c.shader;
@@ skipping 10 matching lines @@
   }
   if (params == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetShaderiv");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   DoGetShaderiv(shader, pname, params);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetShaderiv");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetShaderiv", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetSynciv(uint32_t immediate_data_size,
                                                const void* cmd_data) {
   if (!unsafe_es3_apis_enabled())
     return error::kUnknownCommand;
   const gles2::cmds::GetSynciv& c =
       *static_cast<const gles2::cmds::GetSynciv*>(cmd_data);
@@ skipping 13 matching lines @@
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   GLsync service_sync = 0;
   if (!group_->GetSyncServiceId(sync, &service_sync)) {
     LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, "glGetSynciv", "invalid sync id");
     return error::kNoError;
   }
   glGetSynciv(service_sync, pname, num_values, nullptr, values);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetSynciv");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetSynciv", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetTexParameterfv(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   const gles2::cmds::GetTexParameterfv& c =
       *static_cast<const gles2::cmds::GetTexParameterfv*>(cmd_data);
   (void)c;
@@ skipping 15 matching lines @@
   }
   if (params == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetTexParameterfv");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   DoGetTexParameterfv(target, pname, params);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetTexParameterfv");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetTexParameterfv", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetTexParameteriv(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   const gles2::cmds::GetTexParameteriv& c =
       *static_cast<const gles2::cmds::GetTexParameteriv*>(cmd_data);
   (void)c;
@@ skipping 15 matching lines @@
   }
   if (params == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetTexParameteriv");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   DoGetTexParameteriv(target, pname, params);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetTexParameteriv");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetTexParameteriv", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetVertexAttribfv(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   const gles2::cmds::GetVertexAttribfv& c =
       *static_cast<const gles2::cmds::GetVertexAttribfv*>(cmd_data);
   (void)c;
@@ skipping 11 matching lines @@
   }
   if (params == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetVertexAttribfv");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   DoGetVertexAttribfv(index, pname, params);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetVertexAttribfv");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetVertexAttribfv", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetVertexAttribiv(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   const gles2::cmds::GetVertexAttribiv& c =
       *static_cast<const gles2::cmds::GetVertexAttribiv*>(cmd_data);
   (void)c;
@@ skipping 11 matching lines @@
   }
   if (params == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetVertexAttribiv");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   DoGetVertexAttribiv(index, pname, params);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetVertexAttribiv");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetVertexAttribiv", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetVertexAttribIiv(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   if (!unsafe_es3_apis_enabled())
     return error::kUnknownCommand;
   const gles2::cmds::GetVertexAttribIiv& c =
       *static_cast<const gles2::cmds::GetVertexAttribIiv*>(cmd_data);
   (void)c;
   GLuint index = static_cast<GLuint>(c.index);
   GLenum pname = static_cast<GLenum>(c.pname);
   typedef cmds::GetVertexAttribIiv::Result Result;
   GLsizei num_values = 0;
   GetNumValuesReturnedForGLGet(pname, &num_values);
   Result* result = GetSharedMemoryAs<Result*>(
       c.params_shm_id, c.params_shm_offset, Result::ComputeSize(num_values));
   GLint* params = result ? result->GetData() : NULL;
   if (params == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetVertexAttribIiv");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   DoGetVertexAttribIiv(index, pname, params);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetVertexAttribIiv");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetVertexAttribIiv", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetVertexAttribIuiv(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   if (!unsafe_es3_apis_enabled())
     return error::kUnknownCommand;
   const gles2::cmds::GetVertexAttribIuiv& c =
       *static_cast<const gles2::cmds::GetVertexAttribIuiv*>(cmd_data);
   (void)c;
   GLuint index = static_cast<GLuint>(c.index);
   GLenum pname = static_cast<GLenum>(c.pname);
   typedef cmds::GetVertexAttribIuiv::Result Result;
   GLsizei num_values = 0;
   GetNumValuesReturnedForGLGet(pname, &num_values);
   Result* result = GetSharedMemoryAs<Result*>(
       c.params_shm_id, c.params_shm_offset, Result::ComputeSize(num_values));
   GLuint* params = result ? result->GetData() : NULL;
   if (params == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetVertexAttribIuiv");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
   DoGetVertexAttribIuiv(index, pname, params);
-  GLenum error = glGetError();
+  GLenum error = LOCAL_PEEK_GL_ERROR("GetVertexAttribIuiv");
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
-  } else {
-    LOCAL_SET_GL_ERROR(error, "GetVertexAttribIuiv", "");
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleHint(uint32_t immediate_data_size,
                                           const void* cmd_data) {
   const gles2::cmds::Hint& c = *static_cast<const gles2::cmds::Hint*>(cmd_data);
   (void)c;
   GLenum target = static_cast<GLenum>(c.target);
   GLenum mode = static_cast<GLenum>(c.mode);
@@ skipping 2950 matching lines @@
         state_.enable_flags.cached_primitive_restart_fixed_index = enabled;
         return true;
       }
       return false;
     default:
       NOTREACHED();
       return false;
   }
 }
 #endif  // GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_DECODER_AUTOGEN_H_