Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: sdk/lib/_internal/pub/lib/src/validator/executable.dart

Issue 1165473002: Start pulling pub from its own repo. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Code review changes Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/lib/src/validator/executable.dart
diff --git a/sdk/lib/_internal/pub/lib/src/validator/executable.dart b/sdk/lib/_internal/pub/lib/src/validator/executable.dart
deleted file mode 100644
index 939b443470e8180dd1474c85853537d5359edb0a..0000000000000000000000000000000000000000
--- a/sdk/lib/_internal/pub/lib/src/validator/executable.dart
+++ /dev/null
@@ -1,35 +0,0 @@
-// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-library pub.validator.executable;
-
-import 'dart:async';
-
-import 'package:path/path.dart' as p;
-
-import '../entrypoint.dart';
-import '../validator.dart';
-
-/// Validates that a package's pubspec doesn't contain executables that
-/// reference non-existent scripts.
-class ExecutableValidator extends Validator {
- ExecutableValidator(Entrypoint entrypoint)
- : super(entrypoint);
-
- Future validate() async {
- // TODO(rnystrom): This can print false positives since a script may be
- // produced by a transformer. Do something better.
- var binFiles = entrypoint.root.listFiles(beneath: "bin", recursive: false)
- .map((path) => entrypoint.root.relative(path))
- .toList();
-
- entrypoint.root.pubspec.executables.forEach((executable, script) {
- var scriptPath = p.join("bin", "$script.dart");
- if (binFiles.contains(scriptPath)) return;
-
- warnings.add('Your pubspec.yaml lists an executable "$executable" that '
- 'points to a script "$scriptPath" that does not exist.');
- });
- }
-}
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/validator/directory.dart ('k') | sdk/lib/_internal/pub/lib/src/validator/license.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698