Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Side by Side Diff: sdk/lib/_internal/pub/lib/src/validator/executable.dart

Issue 1165473002: Start pulling pub from its own repo. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Code review changes Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4
5 library pub.validator.executable;
6
7 import 'dart:async';
8
9 import 'package:path/path.dart' as p;
10
11 import '../entrypoint.dart';
12 import '../validator.dart';
13
14 /// Validates that a package's pubspec doesn't contain executables that
15 /// reference non-existent scripts.
16 class ExecutableValidator extends Validator {
17 ExecutableValidator(Entrypoint entrypoint)
18 : super(entrypoint);
19
20 Future validate() async {
21 // TODO(rnystrom): This can print false positives since a script may be
22 // produced by a transformer. Do something better.
23 var binFiles = entrypoint.root.listFiles(beneath: "bin", recursive: false)
24 .map((path) => entrypoint.root.relative(path))
25 .toList();
26
27 entrypoint.root.pubspec.executables.forEach((executable, script) {
28 var scriptPath = p.join("bin", "$script.dart");
29 if (binFiles.contains(scriptPath)) return;
30
31 warnings.add('Your pubspec.yaml lists an executable "$executable" that '
32 'points to a script "$scriptPath" that does not exist.');
33 });
34 }
35 }
OLDNEW
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/validator/directory.dart ('k') | sdk/lib/_internal/pub/lib/src/validator/license.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698