sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_arg_errors_test.dart - Issue 1165473002: Start pulling pub from its own repo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_arg_errors_test.dart

Issue 1165473002: Start pulling pub from its own repo. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Code review changes Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_and_immediately_unserve_test.dart ('k') | sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_overlapping_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_arg_errors_test.dart

diff --git a/sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_arg_errors_test.dart b/sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_arg_errors_test.dart

deleted file mode 100644

index 5bf9f446c6e4ede495e527d5c4b5d7a9116601b6..0000000000000000000000000000000000000000

--- a/sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_arg_errors_test.dart

+++ /dev/null

@@ -1,51 +0,0 @@

-// BSD-style license that can be found in the LICENSE file.

-library pub_tests;

-import 'package:json_rpc_2/error_code.dart' as rpc_error_code;

-import 'package:scheduled_test/scheduled_test.dart';

-import '../../descriptor.dart' as d;

-import '../../test_pub.dart';

-import '../utils.dart';

-main() {

- initConfig();

- setUp(() {

- d.dir(appPath, [

- d.appPubspec(),

- d.dir("web", [

- d.file("index.html", "<body>")

- ])

- ]).create();

- });

- integration("responds with an error if 'path' is not a string", () {

- pubServe();

- expectWebSocketError("serveDirectory", {"path": 123},

- rpc_error_code.INVALID_PARAMS,

- 'Parameter "path" for method "serveDirectory" must be a string, but '

- 'was 123.');

- endPubServe();

- });

- integration("responds with an error if 'path' is absolute", () {

- pubServe();

- expectWebSocketError("serveDirectory", {"path": "/absolute.txt"},

- rpc_error_code.INVALID_PARAMS,

- '"path" must be a relative path. Got "/absolute.txt".');

- endPubServe();

- });

- integration("responds with an error if 'path' reaches out", () {

- pubServe();

- expectWebSocketError("serveDirectory", {"path": "a/../../bad.txt"},

- rpc_error_code.INVALID_PARAMS,

- '"path" cannot reach out of its containing directory. Got '

- '"a/../../bad.txt".');

- endPubServe();

- });