sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_arg_errors_test.dart - Issue 1165473002: Start pulling pub from its own repo.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_arg_errors_test.dart

Issue 1165473002: Start pulling pub from its own repo. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Code review changes Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS d.file

2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.

4

5 library pub_tests;

6

7 import 'package:json_rpc_2/error_code.dart' as rpc_error_code;

8 import 'package:scheduled_test/scheduled_test.dart';

9

10 import '../../descriptor.dart' as d;

11 import '../../test_pub.dart';

12 import '../utils.dart';

13

14 main() {

15 initConfig();

16

17 setUp(() {

18 d.dir(appPath, [

19 d.appPubspec(),

20 d.dir("web", [

21 d.file("index.html", "<body>")

22 ])

23 ]).create();

24 });

25

26 integration("responds with an error if 'path' is not a string", () {

27 pubServe();

28 expectWebSocketError("serveDirectory", {"path": 123},

29 rpc_error_code.INVALID_PARAMS,

30 'Parameter "path" for method "serveDirectory" must be a string, but '

31 'was 123.');

32 endPubServe();

33 });

34

35 integration("responds with an error if 'path' is absolute", () {

36 pubServe();

37 expectWebSocketError("serveDirectory", {"path": "/absolute.txt"},

38 rpc_error_code.INVALID_PARAMS,

39 '"path" must be a relative path. Got "/absolute.txt".');

40 endPubServe();

41 });

42

43 integration("responds with an error if 'path' reaches out", () {

44 pubServe();

45 expectWebSocketError("serveDirectory", {"path": "a/../../bad.txt"},

46 rpc_error_code.INVALID_PARAMS,

47 '"path" cannot reach out of its containing directory. Got '

48 '"a/../../bad.txt".');

49 endPubServe();

50 });

51 }

OLD	NEW