Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1165463007: Build ObjectLiteral constant properties in the numbering phase. (Closed)

Created:
5 years, 6 months ago by mvstanton
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Build ObjectLiteral constant properties in the numbering phase. It's necessary to do this in order to know how many type feedback vector slots we should allocate for the object literal. BUG= Committed: https://crrev.com/450002f3a105d4bb17fd3b1a9d9d54464c01d200 Cr-Commit-Position: refs/heads/master@{#28749}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M src/arm/full-codegen-arm.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/ast-numbering.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mvstanton
Hi Jakob, Here is a short follow-up to the CL that allocates vector slots for ...
5 years, 6 months ago (2015-06-01 12:42:08 UTC) #2
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-01 13:43:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165463007/20001
5 years, 6 months ago (2015-06-02 09:03:31 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-02 09:35:28 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 09:35:34 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/450002f3a105d4bb17fd3b1a9d9d54464c01d200
Cr-Commit-Position: refs/heads/master@{#28749}

Powered by Google App Engine
This is Rietveld 408576698