src/arm/full-codegen-arm.cc - Issue 1165463007: Build ObjectLiteral constant properties in the numbering phase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/full-codegen-arm.cc

Issue 1165463007: Build ObjectLiteral constant properties in the numbering phase. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/full-codegen-arm.cc

diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc

index e87ce45516f0c15eafb8c24ecc1256b34495eeae..c945ce4525044c84d657f7e464c668a3a77fb41a 100644

--- a/src/arm/full-codegen-arm.cc

+++ b/src/arm/full-codegen-arm.cc

@@ -1656,7 +1656,6 @@ void FullCodeGenerator::EmitAccessor(Expression* expression) {

void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {

Comment cmnt(masm_, "[ ObjectLiteral");

- expr->BuildConstantProperties(isolate());

Handle<FixedArray> constant_properties = expr->constant_properties();

__ ldr(r3, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));

__ ldr(r3, FieldMemOperand(r3, JSFunction::kLiteralsOffset));

« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »