chrome/browser/extensions/external_provider_impl.cc - Issue 1165323004: We should use UserID object to identify users instead of username.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_provider_impl.cc

Issue 1165323004: We should use UserID object to identify users instead of username. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc ('K') | « chrome/browser/extensions/extension_system_impl.cc ('k') | chrome/browser/feedback/show_feedback_page.cc » ('j') | chrome/browser/feedback/show_feedback_page.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_provider_impl.cc

diff --git a/chrome/browser/extensions/external_provider_impl.cc b/chrome/browser/extensions/external_provider_impl.cc

index cd7f17ddc8ee54bd7e6ca8bb35f6912d0d20ad4c..b39d5140969011374ff663754fc3180f59f788f7 100644

--- a/chrome/browser/extensions/external_provider_impl.cc

+++ b/chrome/browser/extensions/external_provider_impl.cc

@@ -436,12 +436,12 @@ void ExternalProviderImpl::CreateExternalProviders(

policy::DeviceLocalAccount::Type account_type;

if (user &&

connector->IsEnterpriseManaged() &&

- policy::IsDeviceLocalAccountUser(user->email(), &account_type)) {

+ policy::IsDeviceLocalAccountUser(user->GetUserID(), &account_type)) {

if (account_type == policy::DeviceLocalAccount::TYPE_PUBLIC_SESSION)

is_chrome_os_public_session = true;

policy::DeviceLocalAccountPolicyBroker* broker =

connector->GetDeviceLocalAccountPolicyService()->GetBrokerForUser(

- user->email());

+ user->GetUserID());

if (broker) {

external_loader = broker->extension_loader();

crx_location = Manifest::EXTERNAL_POLICY;