chrome/browser/feedback/show_feedback_page.cc - Issue 1165323004: We should use UserID object to identify users instead of username.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/feedback/show_feedback_page.cc

Issue 1165323004: We should use UserID object to identify users instead of username. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc ('K') | « chrome/browser/extensions/external_provider_impl.cc ('k') | chrome/browser/notifications/profile_notification.cc » ('j') | chrome/browser/profiles/profile_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/feedback/show_feedback_page.cc

diff --git a/chrome/browser/feedback/show_feedback_page.cc b/chrome/browser/feedback/show_feedback_page.cc

index f70a83d0b3cccfa1d04d372d08b7b95eaf9cf6b8..3522e6f44968880dbd9e39b8bc9acaeb6d86b516 100644

--- a/chrome/browser/feedback/show_feedback_page.cc

+++ b/chrome/browser/feedback/show_feedback_page.cc

@@ -66,11 +66,11 @@ void ShowFeedbackPage(Browser* browser,

// Obtains the display profile ID on which the Feedback window should show.

chrome::MultiUserWindowManager* const window_manager =

chrome::MultiUserWindowManager::GetInstance();

- const std::string display_profile_id =

+ const user_manager::UserID display_profile_id =

window_manager && browser

? window_manager->GetUserPresentingWindow(

browser->window()->GetNativeWindow())

- : "";

+ : user_manager::UserID(std::string(), std::string());

Denis Kuznetsov (DE-MUC) 2015/06/10 16:50:44 EmptyUserID

profile = display_profile_id.empty()

? profile

: multi_user_util::GetProfileFromUserID(display_profile_id);