Issue 1165303002: remove covariant generics option

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1165303002: remove covariant generics option (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly

Modified:
5 years, 6 months ago

Reviewers:
vsm, Leaf

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

remove covariant generics option Thoughts? Seems unlikely we'll go with invariant at this point. I'd like to see covariant generics go, but it seems we need variance annotations of some sort before that becomes realistic. (e.g. Iterable is used all over the place) R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/03191c8a046ee660008a0145246bd8fdfbc9d5fa

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -373 lines)			Patch
M	lib/src/checker/rules.dart	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	lib/src/options.dart	View	1	6 chunks	+5 lines, -17 lines	0 comments	Download
M	lib/src/testing.dart	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	test/checker/checker_test.dart	View	1	3 chunks	+2 lines, -348 lines	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

This is the last of the option removing CL's from me ... for now at ...

5 years, 6 months ago (2015-06-08 20:58:30 UTC) #2

Jennifer Messerly

5 years, 6 months ago (2015-06-08 21:36:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
03191c8a046ee660008a0145246bd8fdfbc9d5fa (presubmit successful).