Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: lib/src/options.dart

Issue 1165303002: remove covariant generics option (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/checker/rules.dart ('k') | lib/src/testing.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/options.dart
diff --git a/lib/src/options.dart b/lib/src/options.dart
index 832bab1c9eca5afdbb5b201e6680a400ee377b31..e2711dfbea57d4d1ee023e70a0fa0fdf91c99b5f 100644
--- a/lib/src/options.dart
+++ b/lib/src/options.dart
@@ -73,9 +73,6 @@ class ResolverOptions {
// TODO(vsm): Merge RulesOptions and TypeOptions
/// Options used by our RestrictedRules.
class RulesOptions extends TypeOptions {
- /// Whether to use covariant generics
- final bool covariantGenerics;
-
/// Whether to infer types downwards from local context
final bool inferDownwards;
static const inferDownwardsDefault = true;
@@ -86,9 +83,8 @@ class RulesOptions extends TypeOptions {
/// Whether to use static types for code generation.
final bool ignoreTypes;
- RulesOptions({this.covariantGenerics: true,
- this.inferDownwards: inferDownwardsDefault, this.relaxedCasts: true,
- this.ignoreTypes: false});
+ RulesOptions({this.inferDownwards: inferDownwardsDefault,
+ this.relaxedCasts: true, this.ignoreTypes: false});
}
class JSCodeOptions {
@@ -150,10 +146,6 @@ class CompilerOptions implements RulesOptions, ResolverOptions, JSCodeOptions {
/// Host name or address for HTTP server when [serverMode] is on.
final String host;
- /// Whether to use covariant generics
- @override
- final bool covariantGenerics;
-
/// Whether to inject casts between Dart assignable types.
@override
final bool relaxedCasts;
@@ -214,10 +206,9 @@ class CompilerOptions implements RulesOptions, ResolverOptions, JSCodeOptions {
CompilerOptions({this.checkSdk: false, this.dumpInfo: false,
this.dumpInfoFile, this.forceCompile: false, this.ignoreTypes: false,
- this.outputDir, this.useColors: true, this.covariantGenerics: true,
- this.relaxedCasts: true, this.useMultiPackage: false,
- this.packageRoot: 'packages/', this.packagePaths: const <String>[],
- this.resources: const <String>[],
+ this.outputDir, this.useColors: true, this.relaxedCasts: true,
+ this.useMultiPackage: false, this.packageRoot: 'packages/',
+ this.packagePaths: const <String>[], this.resources: const <String>[],
this.inferDownwards: RulesOptions.inferDownwardsDefault,
this.inferFromOverrides: ResolverOptions.inferFromOverridesDefault,
this.inferTransitively: ResolverOptions.inferTransitivelyDefault,
@@ -283,7 +274,6 @@ CompilerOptions parseOptions(List<String> argv) {
forceCompile: args['force-compile'] || serverMode,
ignoreTypes: args['ignore-types'],
outputDir: outputDir,
- covariantGenerics: args['covariant-generics'],
relaxedCasts: args['relaxed-casts'],
useColors: useColors,
customUrlMappings: customUrlMappings,
@@ -320,8 +310,6 @@ final ArgParser argParser = new ArgParser()
abbr: 's', help: 'Typecheck sdk libs', defaultsTo: false)
..addFlag('mock-sdk',
abbr: 'm', help: 'Use a mock Dart SDK', defaultsTo: false)
- ..addFlag('covariant-generics',
- help: 'Use covariant generics', defaultsTo: true)
..addFlag('ignore-types',
help: 'Ignore types during codegen', defaultsTo: false)
..addFlag('relaxed-casts',
« no previous file with comments | « lib/src/checker/rules.dart ('k') | lib/src/testing.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698