Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2616)

Unified Diff: sandbox/win/sandbox_poc/main_ui_window.cc

Issue 1165283003: vs2015: fix rename of _crt_va_start (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2015-vp8-unittest
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/sandbox_poc/main_ui_window.cc
diff --git a/sandbox/win/sandbox_poc/main_ui_window.cc b/sandbox/win/sandbox_poc/main_ui_window.cc
index 1671424942c9fae12fc560907c3d1d6ad357c1a1..2a4fe11622945abcfa5e265894a3dfa5a028920c 100644
--- a/sandbox/win/sandbox_poc/main_ui_window.cc
+++ b/sandbox/win/sandbox_poc/main_ui_window.cc
@@ -624,7 +624,11 @@ void MainUIWindow::AddDebugMessage(const wchar_t* format, ...) {
const int kMaxDebugBuffSize = 1024;
va_list arg_list;
+#if _MSC_VER >= 1900
+ __crt_va_start(arg_list, format);
Reid Kleckner 2015/06/09 00:37:59 Why not va_start from <stdarg.h>?
scottmg 2015/06/09 16:27:43 No idea, it seemed strange enough that I left it a
scottmg 2015/06/09 16:28:28 Hmm, attributed to one "initial.commit" so I'm gue
scottmg 2015/06/09 16:33:47 and va_start is #defined to [_]_crt_va_start (as y
+#else
_crt_va_start(arg_list, format);
+#endif
wchar_t text[kMaxDebugBuffSize + 1];
vswprintf_s(text, kMaxDebugBuffSize, format, arg_list);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698